csonto/bash-completion
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
bash-completion/contrib
History
Freddy Vulto cfcf9fae8f Quote unquoted $cur to prevent globbing. 
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00
..
_subversion
Do not make vi and friends expand tabs with spaces.
2009-01-17 11:38:33 +02:00
_yum
Split yum into _yum and yum-arch.
2009-09-08 20:28:51 +03:00
ant
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
apache2ctl
Trim trailing whitespace (cosmetic, no functional changes).
2009-07-25 13:38:42 +03:00
apt
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
apt-build
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
aptitude
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
aspell
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
autorpm
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
bash-builtins
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
bind-utils
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
bitkeeper
Add missing 'have foo's.
2009-06-08 21:22:43 +03:00
bittorrent
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
bluez-utils
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
brctl
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
bzip2
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
cardctl
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
cfengine
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
chkconfig
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
chsh
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
cksfv
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
clisp
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
configure
split configure completion
2009-06-08 16:51:48 +02:00
cowsay
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
cpan2dist
Trim trailing whitespace (cosmetic, no functional changes).
2009-07-25 13:38:42 +03:00
cpio
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
cups
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
cvs
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
dcop
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
dd
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
dhclient
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
dict
Add indentation settings.
2009-06-06 00:48:22 +03:00
dpkg
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
dselect
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
dsniff
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
findutils
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
freeciv
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
gcc
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
gcl
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
gdb
Reviewed tests g*
2009-07-18 09:43:25 +02:00
genisoimage
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
getent
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
gkrellm
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
gnatmake
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
gpg
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
gpg2
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
gzip
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
harbour
Do not make vi and friends expand tabs with spaces.
2009-01-17 11:38:33 +02:00
heimdal
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
iconv
Add indentation settings.
2009-06-06 00:48:22 +03:00
imagemagick
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
info
Support .xz suffix in info page completions.
2009-09-21 00:47:03 +03:00
ipmitool
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
iptables
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
isql
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
jar
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
java
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
kldload
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
larch
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
ldapvi
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
lftp
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
lilo
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
lilypond
Do not make vi and friends expand tabs with spaces.
2009-01-17 11:38:33 +02:00
links
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
lisp
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
lvm
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
lzma
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
lzop
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
mailman
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
make
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
man
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
mc
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
mcrypt
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
mdadm
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
minicom
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
mkinitrd
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
mock
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
modules
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
monodevelop
Trim trailing whitespace (cosmetic, no functional changes).
2009-07-25 13:38:42 +03:00
mplayer
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
msynctool
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
mtx
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
munin-node
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
mutt
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
mysqladmin
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
ncftp
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
net-tools
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
ntpdate
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
openldap
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
openssl
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
p4
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
perl
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
pine
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
pkg_install
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
pkg-config
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
pkgtools
Split Slackware pkgtools completion to contrib/pkgtools.
2009-06-08 20:49:52 +03:00
portupgrade
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
postfix
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
postgresql
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
povray
Fixed povray indentation
2009-07-29 22:09:45 +02:00
python
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
qdbus
Trim trailing whitespace (cosmetic, no functional changes).
2009-07-25 13:38:42 +03:00
qemu
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
quota-tools
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
rcs
split rcs completion
2009-05-27 18:45:51 +02:00
rdesktop
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
repomanage
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
reportbug
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
resolvconf
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
rfkill
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
ri
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
rpcdebug
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
rpm
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
rpmcheck
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
rrdtool
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
rsync
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
samba
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
sbcl
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
screen
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
shadow
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
sitecopy
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
smartctl
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
snownews
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
ssh
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
strace
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
svk
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
sysctl
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
sysv-rc
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
tar
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
tcpdump
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
unace
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
unrar
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
update-alternatives
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
vncviewer
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
vpnc
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
wireless-tools
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
wodim
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
wvdial
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
xhost
Gave _known_hosts_real mandatory argument CWORD
2009-07-03 22:28:13 +02:00
xm
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
xmllint
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
xmlwf
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
xmms
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
xrandr
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
xz
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
yp-tools
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00
yum-arch
Quote unquoted $cur to prevent globbing.
2009-09-25 09:36:29 +02:00