Freddy Vulto cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00

135 lines
2.3 KiB
Bash

# -*- mode: shell-script; sh-basic-offset: 8; indent-tabs-mode: t -*-
# ex: ts=8 sw=8 noet filetype=sh
#
# bash completion for heimdal
have ktutil && {
_heimdal_principals()
{
COMPREPLY=( $( compgen -W "$( kadmin -l dump 2>/dev/null | \
awk '{print $1}' )" -- "$cur" ) )
}
_heimdal_realms()
{
COMPREPLY=( $( compgen -W "( kadmin -l dump 2>/dev/null | \
awk '{print $1}' | awk -F @ '{print $2}' )" -- "$cur" ) )
}
_heimdal_encodings()
{
COMPREPLY=( $( compgen -W 'des-cbc-mcrc des-cbc-md4 des-cbc-md5 \
des3-cbc-sha1 arcfour-hmac-md5 aes128-cts-hmac-sha1-96 \
aes256-cts-hmac-sha1-96' -- "$cur" ) )
}
_ktutil()
{
local cur prev command options split=false
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
_split_longopt && split=true
case $prev in
-p|--principal)
_heimdal_principals
return 0
;;
-e|--enctype)
_heimdal_encodings
return 0
;;
-a|--admin-server)
_known_hosts_real "$cur"
return 0
;;
-r|--realm)
_heimdal_realms
return 0
;;
-@(s|k|-@(srv|key)tab))
_filedir
return 0
;;
esac
$split && return 0
commands='add change copy get list remove rename purge srvconvert \
srv2keytab srvcreate key2srvtab'
for (( i=1; i < COMP_CWORD; i++ )); do
case ${COMP_WORDS[i]} in
-@(k|-keytab))
i=$(($i+1))
;;
-*)
;;
*)
command=${COMP_WORDS[i]}
break
;;
esac
done
if [[ "$cur" == -* ]]; then
case $command in
add)
options='-p --principal -V -e --enctype -w \
--password -r --random -s --no-salt \
-h --hex'
;;
change)
options='-r --realm -a --admin-server -s \
--server-port'
;;
get)
options='-p --principal -e --enctype -r \
--realm -a --admin-server -s server \
--server-port'
;;
list)
options='--keys --timestamp'
;;
remove)
options='-p --principal -V --kvno -e --enctype'
;;
purge)
options='--age'
;;
@(srv2keytab|key2srvtab))
options='-s --srvtab'
;;
*)
options='-k --keytab -v --verbose --version \
-v --help'
;;
esac
COMPREPLY=( $( compgen -W "$options" -- "$cur" ) )
else
case $command in
copy)
_filedir
;;
get)
_heimdal_principals
;;
rename)
_heimdal_principals
;;
*)
COMPREPLY=( $( compgen -W "$commands" -- "$cur" ) )
;;
esac
fi
}
complete -F _ktutil ktutil
}