Freddy Vulto cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00

90 lines
1.9 KiB
Bash

# -*- mode: shell-script; sh-basic-offset: 8; indent-tabs-mode: t -*-
# ex: ts=8 sw=8 noet filetype=sh
#
# bash completion for cfengine
have cfagent && {
_cfagent_options()
{
COMPREPLY=( $( compgen -W '-a --sysadm -b --force-net-copy -c \
--no-check-files -C --no-check-mounts -d --debug -D --define \
-e --no-edits -E --enforce-links -f --file -h --help -H \
--no-hard-classes -i --no-ifconfig -I --inform -k --no-copy \
-K --no-lock -l --traverse-links -L --delete-stale-links -m \
--no-mount -M --no-modules -n --recon --dry-run --just-print \
-N --negate --undefine -p --parse-only -P --no-processes -q \
--no-splay -s --no-commands -S --silent -t --no-tidy -u \
--use-env -U --underscore-classes -v --verbose -V --version \
-x --no-preconf -X --no-links -w --no-warn --quiet' -- "$cur" ) )
}
_cfagent()
{
local cur prev
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
case $prev in
-@(f|-file))
_filedir
return 0
;;
esac
if [[ "$cur" == -* ]]; then
_cfagent_options
fi
}
complete -F _cfagent cfagent
_cfrun()
{
local i section cfinputs
COMPREPLY=()
cur=`_get_cword`
section=1
for (( i=1; i < COMP_CWORD; i++ )); do
if [[ "${COMP_WORDS[i]}" == -- ]]; then
section=$((section + 1))
fi
done
case $section in
1)
prev=${COMP_WORDS[COMP_CWORD-1]}
case $prev in
-f)
_filedir
return 0
;;
esac
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-f -h -d -S -T -v' \
-- $cur ) )
else
hostfile=${CFINPUTS:-/var/lib/cfengine/inputs}/cfrun.hosts
for (( i=1; i < COMP_CWORD; i++ )); do
if [[ "${COMP_WORDS[i]}" == -f ]]; then
hostfile=${COMP_WORDS[i+1]}
break
fi
done
[ ! -f $hostfile ] && return 0
COMPREPLY=( $(compgen -W "$( grep -v \
-E '(=|^$|^#)' $hostfile )" -- "$cur" ) )
fi
;;
2)
_cfagent_options
;;
esac
}
complete -F _cfrun cfrun
}