Freddy Vulto cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00

87 lines
2.3 KiB
Bash

# -*- mode: shell-script; sh-basic-offset: 8; indent-tabs-mode: t -*-
# ex: ts=8 sw=8 noet filetype=sh
#
# module completion by Ted Stern <stern@cray.com>
#
# Completion for Environment Modules `module' alias.
#
# See http://sourceforge.net/projects/modules/
# http://modules.sourceforge.net/
#
# There are several versions of modules that are commonly used. Older
# Cray UNICOS systems and many other sites use 2.2.2b. The latest GPL'd
# version is 3.1.6. But the module alias is somewhat self-documenting
# via the `module help' command, so use that to print the options.
#
# Programmable completion might be more difficult under tcsh since the
# module command is an alias, and the `module avail' command returns
# its output as stderr.
# Test for existence of /etc/profile.d/modules.sh too because we may end up
# being sourced before it and thus before the `module' alias has been defined.
have module || [ -f /etc/profile.d/modules.sh ] && {
_module_list ()
{
local modules="$( echo $LOADEDMODULES | sed 's/:/ /g' | sort )"
compgen -W "$modules" -- $1
}
_module_path ()
{
local modules="$( echo $MODULEPATH | sed 's/:/ /g' | sort )"
compgen -W "$modules" -- $1
}
_module_avail ()
{
local modules="$( \
module avail 2>&1 | \
egrep -v '^(-|$)' | \
xargs printf '%s\n' | sort )"
compgen -W "$modules" -- $1
}
# A completion function for the module alias
_module () {
local cur prev options
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
if [ $COMP_CWORD -eq 1 ] ; then
# First parameter on line -- we expect it to be a mode selection
options="$( module help 2>&1 | egrep '^[[:space:]]*\+' | \
awk '{print $2}' | sed -e 's/|/ /g' | sort )"
COMPREPLY=( $(compgen -W "$options" -- "$cur") )
elif [ $COMP_CWORD -eq 2 ] ; then
case "$prev" in
@(add|display|help|load|show|whatis))
COMPREPLY=( $(_module_avail "$cur") )
;;
@(rm|switch|swap|unload|update))
COMPREPLY=( $(_module_list "$cur") )
;;
unuse)
COMPREPLY=( $(_module_path "$cur") )
;;
esac
elif [ $COMP_CWORD -eq 3 ] ; then
case ${COMP_WORDS[1]} in
@(sw?(ap|itch)))
COMPREPLY=( $(_module_avail "$cur") )
;;
esac
fi
return 0
}
complete -F _module $default module
}