Freddy Vulto cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00

94 lines
2.8 KiB
Bash

# -*- mode: shell-script; sh-basic-offset: 8; indent-tabs-mode: t -*-
# ex: ts=8 sw=8 noet filetype=sh
#
# bash completion for aspell
have aspell && {
_aspell_dictionary()
{
local datadir
datadir=$( aspell config data-dir 2>/dev/null || echo /usr/lib/aspell )
# First, get aliases (dicts dump does not list them)
COMPREPLY=( $( command ls $datadir/*.alias 2>/dev/null ) )
COMPREPLY=( ${COMPREPLY[@]%.alias} )
COMPREPLY=( ${COMPREPLY[@]#$datadir/} )
# Then, add the canonical dicts
COMPREPLY=( "${COMPREPLY[@]}" $( aspell dicts 2>/dev/null ) )
COMPREPLY=( $( compgen -W '${COMPREPLY[@]}' -- "$cur" ) )
}
_aspell()
{
local cur prev split=false
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
_split_longopt && split=true
case "$prev" in
-c|-p|check|--@(conf|personal|repl|per-conf))
_filedir
return 0
;;
--@(conf-dir|data-dir|dict-dir|home-dir|local-data-dir|prefix))
_filedir -d
return 0
;;
dump|create|merge)
COMPREPLY=( $( compgen -W 'master personal repl' -- "$cur" ) )
return 0
;;
--mode)
COMPREPLY=( $( compgen -W 'none url email sgml tex' -- "$cur" ) )
return 0
;;
--sug-mode)
COMPREPLY=( $( compgen -W 'ultra fast normal bad-speller' -- "$cur" ) )
return 0
;;
--keymapping)
COMPREPLY=( $( compgen -W 'aspell ispell' -- "$cur" ) )
return 0
;;
-d|--master)
_aspell_dictionary
return 0
;;
esac
$split && return 0
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '--conf --conf-dir --data-dir --dict-dir \
--encoding --add-filter --rem-filter --mode -e \
-H -t --add-extra-dicts --rem-extra-dicts \
--home-dir -W --ignore --ignore-accents \
--dont-ignore-accents --ignore-case --dont-ignore-case \
--ignore-repl --dont-ignore-repl --jargon --keyboard \
--lang --language-tag --local-data-dir -d --master \
--module --add-module-search-order \
--rem-module-search-order --per-conf -p --personal \
--prefix --repl -C -B --run-together --dont-run-together \
--run-together-limit --run-together-min --save-repl \
--dont-save-repl --set-prefix --dont-set-prefix --size \
--spelling --strip-accents --dont-strip-accents \
--sug-mode --add-word-list-path --rem-word-list-path \
-b -x --backup -b|-x --dont-backup --reverse --dont-reverse \
--time --dont-time --keymapping --add-email-quote \
--rem-email-quote --email-margin --add-tex-command \
--rem-tex-command --tex-check-comments \
--dont-tex-check-comments --add-tex-extension \
--rem-tex-extension --add-sgml-check --rem-sgml-check \
--add-sgml-extension --rem-sgml-extension' -- "$cur" ) )
else
COMPREPLY=( $( compgen -W '-? help -c check -a pipe -l list \
config config soundslike filter -v version dump \
create merge' -- "$cur" ) )
fi
}
complete -F _aspell $filenames aspell
}