Freddy Vulto cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00

71 lines
1.7 KiB
Bash

# -*- mode: shell-script; sh-basic-offset: 8; indent-tabs-mode: t -*-
# ex: ts=8 sw=8 noet filetype=sh
#
# bash completion for ldapvi
have ldapvi &&
_ldapvi()
{
local cur prev
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
case "$prev" in
-@(h|-host))
_known_hosts_real "$cur"
return 0
;;
-@(Y|-sasl-mech))
COMPREPLY=( $( compgen -W 'EXTERNAL GSSAPI DIGEST-MD5 \
CRAM-MD5 PLAIN ANONYMOUS' -- "$cur" ) )
return 0
;;
--bind)
COMPREPLY=( $( compgen -W 'simple sasl' -- "$cur" ) )
return 0
;;
--bind-dialog)
COMPREPLY=( $( compgen -W 'never auto always' \
-- $cur ) )
return 0
;;
--scope)
COMPREPLY=( $( compgen -W 'base one sub' -- "$cur" ) )
return 0
;;
--deref)
COMPREPLY=( $( compgen -W 'never searching finding \
always' -- "$cur" ) )
return 0
;;
--encoding)
COMPREPLY=( $( compgen -W 'ASCII UTF-8 binary' \
-- "$cur" ) )
return 0
;;
--tls)
COMPREPLY=( $( compgen -W 'never allow try strict' \
-- "$cur" ) )
return 0
;;
esac
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '--discover --out --in --delete \
--rename -h --host -D --user -w --password --bind \
--bind-dialog -I --sasl-interactive --bind-dialog -O \
--sasl-secprops -Q --sasl-quiet -R --sasl-realm -U \
--sasl-authcid -X --sasl-authzid -Y --sasl-mech -b \
--base -s --scope -S --sort --add -o --class --config \
-c --continue --deleteoldrdn -a --deref -d --discover \
-A --empty --ncoding -H --help --ldap-conf -m --may -M \
--managedsait --noquestions -! --noninteractive -q \
--quiet -R --read -Z --starttls --tls -v --verbose \
--ldapsearch --ldapmodify --ldapdelete --ldapmoddn' \
-- "$cur" ) )
fi
} &&
complete -F _ldapvi ldapvi