Freddy Vulto cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00

82 lines
2.0 KiB
Bash

# -*- mode: shell-script; sh-basic-offset: 8; indent-tabs-mode: t -*-
# ex: ts=8 sw=8 noet filetype=sh
#
# mcrypt(1) completion by Ariel Fermani <the_end@bbs.frc.utn.edu.ar>
have mcrypt || have mdecrypt &&
_mcrypt()
{
local cur prev i decrypt
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
case "$prev" in
-@(g|-openpgp-z))
COMPREPLY=( $( compgen -W '0 1 2 3 4 5 6 7 8 9' \
-- "$cur" ) )
return 0
;;
-@(o|-keymode))
COMPREPLY=( $( compgen -W '$( mcrypt --list-keymodes \
2>/dev/null )' -- "$cur" ) )
return 0
;;
-@(m|-mode))
COMPREPLY=( $( compgen -W "$( mcrypt --list \
2>/dev/null | sed -e 's/.*: //' -e 's/ $//' | \
sort | uniq )" -- "$cur" ) )
return 0
;;
-@(a|-algorithm))
COMPREPLY=( $( compgen -W "$( mcrypt --list \
2>/dev/null | awk '{print $1}' )" -- "$cur" ) )
return 0
;;
-@(h|-hash))
COMPREPLY=( $( compgen -W '$( mcrypt --list-hash \
2>/dev/null | sed -e 1d )' -- "$cur" ) )
return 0
;;
-@(k|s|-@(key?(size))))
return 0
;;
-@(f|c|-@(keyfile|config)))
_filedir
return 0
;;
--@(algorithm|mode)s-directory)
_filedir -d
return 0
;;
esac
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-g --openpgp --openpgp-z -d \
--decrypt -s --keysize -o --keymode -f --keyfile \
-c --config -a --algorithm --algorithms-directory \
-m --mode --modes-directory -h --hash -k --key \
--noiv -b --bare -z --gzip -p --bzip2 --flush -l \
--doublecheck -u --unlink --nodelete -t --time -F \
--force --echo -r --random --list --list-keymodes \
--list-hash -V --verbose -q --quiet --help -v \
--version -L --license' -- "$cur" ) )
elif [[ ${COMP_WORDS[0]} == mdecrypt ]]; then
_filedir '@(nc)'
else
decrypt=0
for (( i=1; i < ${#COMP_WORDS[@]}-1; i++ )); do
if [[ ${COMP_WORDS[i]} == -@(d|-decrypt) ]]; then
_filedir '@(nc)'
decrypt=1
break
fi
done
if [[ $decrypt -eq 0 ]]; then
_filedir
fi
fi
} &&
complete $filenames -F _mcrypt mcrypt mdecrypt