Freddy Vulto cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00

304 lines
5.1 KiB
Bash

# -*- mode: shell-script; sh-basic-offset: 8; indent-tabs-mode: t -*-
# ex: ts=8 sw=8 noet filetype=sh
#
# bash completion for samba
have smbclient && {
_samba_resolve_order()
{
COMPREPLY=( $( compgen -W 'lmhosts host wins bcast' -- "$cur" ) )
}
_samba_domains()
{
if [ -n "${COMP_SAMBA_SCAN:-}" ]; then
COMPREPLY=( $( compgen -W '$( smbtree -N -D )' -- "$cur" ) )
fi
}
_samba_hosts()
{
if [ -n "${COMP_SAMBA_SCAN:-}" ]; then
COMPREPLY=( $( compgen -W "$( smbtree -N -S | \
sed -ne 's/^[[:space:]]*\\\\*\([^[:space:]]*\).*/\1/p' \
)" -- $cur ) )
fi
}
_samba_debuglevel()
{
COMPREPLY=( $( compgen -W '0 1 2 3 4 5 6 7 8 9 10' -- "$cur" ) )
}
_smbclient()
{
local cur prev split=false
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
_split_longopt && split=true
case $prev in
-R)
_samba_resolve_order
return 0;
;;
-t)
COMPREPLY=( $( compgen -W 'SJIS EUC JIS7 JIS8 JUNET \
HEX CAP' -- "$cur" ) )
return 0;
;;
-s|-A|--authentication-file)
_filedir
return 0;
;;
-l|--log-basename|-D)
_filedir -d
return 0;
;;
-O)
COMPREPLY=( $( compgen -W 'SO_KEEPALIVE SO_REUSEADDR \
SO_BROADCAST TCP_NODELAY IPTOS_LOWDELAY \
IPTOS_THROUGHPUT SO_SNDBUF SO_RCVBUF \
SO_SNDLOWAT SO_RCVLOWAT' -- "$cur" ) )
return 0;
;;
-T)
COMPREPLY=( $( compgen -W 'c x I X F b g q r N a' -- \
"$cur" ) )
return 0;
;;
-W|--workgroup)
_samba_domains
return 0;
;;
-d|--debuglevel)
_samba_debuglevel
return 0
;;
-p|--port|-M|-I|-b|-U|--user|-n|-i|-T|-c)
# argument required but no completions available
return 0
;;
-\?|--help|-V|--version)
# all other arguments are noop with these
return 0
;;
esac
$split && return 0
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-b -d -L -U -I -M -m -A -N -i -O \
-p -R -s -k -P -c -D -W -l -E --debuglevel \
--log-basename --workgroup' -- "$cur" ) )
fi
}
complete -F _smbclient smbclient
_smbget()
{
local cur prev split=false
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
_split_longopt && split=true
case $prev in
-@(o|f|-outputfile|-rcfile))
_filedir
return 0;
;;
-d|--debuglevel)
_samba_debuglevel
return 0
;;
esac
$split && return 0
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-a --guest -r --resume -R \
--recursive -u --username -p --password -w \
--workgroup -n --nonprompt -d --debuglevel -D --dots \
-P --keep-permissions -o --outputfile -f --rcfile -q \
--quiet -v --verbose -b --blocksize -? --help --usage' \
-- "$cur" ) )
fi
}
complete -F _smbget smbget
_smbcacls()
{
local cur prev split=false
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
_split_longopt && split=true
case $prev in
-s)
_filedir
return 0;
;;
-l|--log-basename)
_filedir -d
return 0;
;;
-d|--debuglevel)
_samba_debuglevel
return 0
;;
esac
$split && return 0
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-a -M -D -S -U -C -G --numeric -t \
-h --help -V -s -d --debuglevel -l --log-basename' -- \
"$cur" ) )
fi
}
complete -F _smbcacls smbcacls
_smbcquotas()
{
local cur prev split=false
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
_split_longopt && split=true
case $prev in
-s|-A|--authentication-file)
_filedir
return 0;
;;
-l|--log-basename)
_filedir -d
return 0;
;;
-d|--debuglevel)
_samba_debuglevel
return 0
;;
esac
$split && return 0
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-u -L -F -S -n -t -v -h --help -V \
-s -d --debuglevel -l --log-basename -N -k -A \
--authentication-file -U --user' -- "$cur" ) )
fi
}
complete -F _smbcquotas smbcquotas
_smbpasswd()
{
local cur prev
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
case $prev in
-r)
_samba_hosts
return 0;
;;
-R)
_samba_resolve_order
return 0;
;;
-c)
_filedir
return 0;
;;
-D)
_samba_debuglevel
return 0
;;
esac
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-a -c -x -d -e -D -n -r -R -m -U -h \
-s -w -W -i -L' -- "$cur" ) )
fi
}
complete -F _smbpasswd smbpasswd
_smbtar()
{
local cur prev
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
case $prev in
-@(r|t))
_filedir tar
return 0;
;;
-s)
_samba_hosts
return 0;
;;
-l)
_samba_debuglevel
return 0
;;
esac
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-r -i -a -v -s -p -x -X -N -b -d -l \
-u -t' -- "$cur" ) )
fi
}
complete -F _smbtar smbtar
_smbtree()
{
local cur prev split=false
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
_split_longopt && split=true
case $prev in
-s|-A|--authentication-file)
_filedir
return 0;
;;
-l|--log-basename)
_filedir -d
return 0;
;;
-d|--debuglevel)
_samba_debuglevel
return 0
;;
esac
$split && return 0
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-b -D -S -V -s -d --debuglevel -l \
--log-basename -N -k -A --authentication-file -U --user\
-h --help' -- "$cur" ) )
fi
}
complete -F _smbtree smbtree
}