Freddy Vulto cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00

100 lines
2.0 KiB
Bash

# -*- mode: shell-script; sh-basic-offset: 8; indent-tabs-mode: t -*-
# ex: ts=8 sw=8 noet filetype=sh
#
# bash completion for strace
have strace &&
_strace()
{
local cur prev offset i syscalls arch unistd
# check if we're still completing strace
offset=0
for (( i=1; i <= COMP_CWORD; i++ )); do
case ${COMP_WORDS[$i]} in
-@(o|e|p))
i=$((i+1))
continue
;;
-*)
continue
;;
esac
offset=$i
break
done
if [ $offset -gt 0 ]; then
# FAIL: _command_offset is not defined anywhere. Guillame?
_command_offset $offset
else
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
case $prev in
-e)
if [[ "$cur" == *=* ]]; then
prev=${cur/=*/}
cur=${cur/*=/}
# Import arch-specific syscalls -- not foolproof IMHO
#+ --David Paleino
arch=$(command uname -m)
syscalls=$(awk '/^#define __NR/ {print $2}' \
/usr/include/asm/unistd.h | sed -e \
's/__NR_//')
if [ -z "$syscalls" ]; then
if [[ "$arch" =~ 86$ ]]; then
unistd=/usr/include/asm/unistd_32.h
else
unistd=/usr/include/asm/unistd_64.h
fi
syscalls=$(awk '/^#define __NR/ {print $2}' \
$unistd | sed -e 's/__NR_//')
fi
case $prev in
trace)
COMPREPLY=( $( compgen -W "$syscalls file process \
network signal ipc desc all none" -- "$cur") )
return 0
;;
esac
else
COMPREPLY=( $( compgen -S"=" -W 'trace abbrev \
verbose raw signal read write' \
-- "$cur" ) )
fi
return 0
;;
-o)
_filedir
return 0
;;
-p)
_pids
return 0
;;
-S)
COMPREPLY=( $( compgen -W 'time calls name nothing' -- "$cur" ) )
return 0
;;
-u)
COMPREPLY=( $( compgen -u -- "$cur" ) )
return 0
;;
esac
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-c -d -f -ff -F -h --help -i -q \
-r -t -tt -ttt -T -v -V -x -xx -a -e -o -O -p \
-s -S -u -E' -- "$cur" ) )
else
COMPREPLY=( $( compgen -c -- "$cur" ) )
fi
fi
} &&
complete -F _strace $default strace