Freddy Vulto cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00

145 lines
3.0 KiB
Bash

# -*- mode: shell-script; sh-basic-offset: 8; indent-tabs-mode: t -*-
# ex: ts=8 sw=8 noet filetype=sh
#
# bash completion for smartctl(8)
have smartctl && {
_smartctl_quietmode()
{
COMPREPLY=( $( compgen -W 'errorsonly silent noserial' -- "$cur" ) )
}
_smartctl_device()
{
local i opts='ata scsi sat marvell hpt cciss'
for (( i=0; i <= 31; i++ )) ; do
opts="$opts 3ware,$i"
done
COMPREPLY=( $( compgen -W "$opts" -- "$cur" ) )
}
_smartctl_tolerance()
{
COMPREPLY=( $( compgen -W 'normal conservative permissive \
verypermissive' -- "$cur" ) )
}
_smartctl_badsum()
{
COMPREPLY=( $( compgen -W 'warn exit ignore' -- "$cur" ) )
}
_smartctl_report()
{
COMPREPLY=( $( compgen -W 'ioctl ataioctl scsiioctl' -- "$cur" ) )
}
_smartctl_powermode()
{
COMPREPLY=( $( compgen -W 'never sleep standby idle' -- "$cur" ) )
}
_smartctl_feature()
{
COMPREPLY=( $( compgen -W 'on off' -- "$cur" ) )
}
_smartctl_log()
{
COMPREPLY=( $( compgen -W 'error selftest selective directory' -- "$cur" ) )
}
_smartctl_vendorattribute()
{
COMPREPLY=( $( compgen -W 'help 9,minutes 9,seconds 9,halfminutes \
9,temp 192,emergencyretractcyclect 193,loadunload \
194,10xCelsius 194,unknown 198,offlinescanuncsectorct \
200,writeerrorcount 201,detectedtacount 220,temp' -- "$cur" ) )
}
_smartctl_firmwarebug()
{
COMPREPLY=( $( compgen -W 'none samsung samsung2 samsung3 swapid' \
-- "$cur" ) )
}
_smartctl_presets()
{
COMPREPLY=( $( compgen -W 'use ignore show showall' -- "$cur" ) )
}
_smartctl_test()
{
COMPREPLY=( $( compgen -W 'offline short long conveyance select \
afterselect,on afterselect,off pending scttempint' -- "$cur" ) )
}
_smartctl()
{
local cur prev split=false
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
_split_longopt && split=true
case "$prev" in
-q|--quietmode)
_smartctl_quietmode
;;
-d|--device)
_smartctl_device
return 0
;;
-t|--tolerance)
_smartctl_tolerance
return 0
;;
-b|--badsum)
_smartctl_badsum
return 0
;;
-r|--report)
_smartctl_report
return 0
;;
-n|--nocheck)
_smartctl_powermode
return 0
;;
-s|--smart|-o|--offlineauto|-S|--saveauto)
_smartctl_feature
return 0
;;
-l|--log)
_smartctl_log
return 0
;;
-v|--vendorattribute)
_smartctl_vendorattribute
return 0
;;
-F|--firmwarebug)
_smartctl_firmwarebug
return 0
;;
-P|--presets)
_smartctl_presets
return 0
;;
-t|--test)
_smartctl_test
return 0
;;
esac
$split && return 0
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-h --help --usage -V --version \
--copyright --license-i --info -a --all -q \
--quietmode -d --device -T --tolerance -b --badsum \
-r --report -n --nocheck -s --smart -o --offlineauto \
-S --saveauto -H --health -c --capabilities -A \
--attributes -l --log -v --vendorattribute -F \
--firmwarebug -P --presets -t --test -C \
--captive -X --abort' -- "$cur" ) )
else
cur=${cur:=/dev/}
_filedir
fi
}
complete -F _smartctl smartctl
}