Freddy Vulto cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00

54 lines
1.4 KiB
Bash

# -*- mode: shell-script; sh-basic-offset: 8; indent-tabs-mode: t -*-
# ex: ts=8 sw=8 noet filetype=sh
#
# lzop(1) completion
have lzop &&
_lzop()
{
local cur prev xspec
COMPREPLY=()
cur=`_get_cword`
prev=${COMP_WORDS[COMP_CWORD-1]}
# TODO: -p: takes a dir argument, without a separating space
if [[ "$cur" == -* ]]; then
COMPREPLY=( $( compgen -W '-d -x -l -t -h -I -V -L -1 -2 -3 \
-4 -5 -6 -7 -8 -9 -q -v -c -f -F -n -N -P -k -U -o \
-S --fast --best --decompress --uncompress --extract \
--test --list --ls --info --sysinfo --license --help \
--version --stdout --to-stdout --output --path \
--force --no-checksum --no-name --name --no-mode \
--no-time --suffix --keep --unlink --delete --crc32 \
--no-warn --ignore-warn --quiet --silent --verbose \
--no-stdin --filter --checksum --no-color --mono \
--color' -- "$cur" ) )
return 0
fi
case "$prev" in
-o|--output) _filedir ; return 0 ;;
--path) _filedir -d ; return 0 ;;
-S|--suffix) return 0 ;;
esac
xspec="*.?(t)lzo"
case "$prev" in
--@(@(de|un)compress|extract|list|ls|info|test))
xspec="!"$xspec ;;
--force) xspec= ;;
--*) ;;
-*f*|'<'|'>') xspec= ;;
-*[dltx]*) xspec="!"$xspec ;;
esac
_expand || return 0
local IFS=$'\t\n'
COMPREPLY=( $( compgen -f -X "$xspec" -- "$cur" ) \
$( compgen -d -- "$cur" ) )
} &&
complete -F _lzop $filenames lzop