* Remove unused parameters
* Fix several "comparison between signed and unsigned" warnings
* Move some variables into a more local scope
* Mark several unused parameters with WZ_DECL_UNUSED for callback functions
* Give some variables decent names (e.g. 'j' is ''not'' a good name for a variable holding a player number)
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6170 4a71c877-e1ca-e34f-864e-861f7616d084
* Move these constants in the smallest scope where they're used
* Fix a "comparison between signed and unsigned" warning
* Move a variable into a more local scope
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6169 4a71c877-e1ca-e34f-864e-861f7616d084
* Don't cast one operand in an expression to double only to use a float ("single") number as the other operand in the expression
* Use sstrcpy and sstrcat's return values to determine whether string truncation occurred
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6168 4a71c877-e1ca-e34f-864e-861f7616d084
- (true and false are even worse than magic numbers when they're used to represent non-boolean values, i.e. abused for the fact that they happen to be defined to 1 and 0 respectively.
* This change *will* affect the way how FMV subtitles are displayed; this could be considered a bugfix, or not...
- See the changes to seqdisp.c around line 680 and keep in mind that true = 1; and SEQ_TEXT_JUSTIFY = 2;
- Looking at the commented out code I think SEQ_TEXT_JUSTIFY is intented, though due to true being 1 we've effectively been using SEQ_TEXT_FOLLOW_ON instead since r1, see browser:trunk/game/src/seqDisp.c@1#L1121
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6166 4a71c877-e1ca-e34f-864e-861f7616d084
* Use this enum as parameter type instead of mixed SDWORD and BOOLs (BOOLs are serious abuse here!!!)
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6165 4a71c877-e1ca-e34f-864e-861f7616d084
* Remove several unused parameters
* Fix several "comparison between signed and unsigned" warnings
* Move variables into a more local scope where possible
* Merge the conditions of some nested if-statements
* Use an enum instead of some "magically defined" macros
* Remove unused functions tooNearEdge and demoRequestStart
* Mark function findSomethingInteresting as static
* Use ARRAY_SIZE(array) instead of sizeof(array) / sizeof(array[0])
* Get rid of some unnecessary casting from float to int
* Mark several unused parameters with WZ_DECL_UNUSED for callback functions
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6161 4a71c877-e1ca-e34f-864e-861f7616d084
* Mark several parameters that aren't being used (but shouldn't be removed) with WZ_DECL_UNUSED
* Use "(unsigned )?int" instead of "[SU](D?WORD|BYTE)" where the size guarantee is not required
* Instead of "(X - Y) >= 0" use the logically equivalent and more readable "X >= Y"
* Remove redundant function prototypes
* Move variables into a more local scope where possible
* Assign the result of an expression to a variable once so that the expression doesn't have to be duplicated several times
* Move constant UNALLOCATED_OBJECT out of the header and into the only source file where it's ever used
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6160 4a71c877-e1ca-e34f-864e-861f7616d084
* Fix several "comparison between signed and unsigned" warnings
* Use ARRAY_SIZE(array) instead of sizeof(array) / sizeof(typeof(*array))
* Const correctness
* Use "(unsigned )?int" instead of "[SU](D?WORD|BYTE)" where the size guarantee is not required
* Use "%u" as format specifier for unsigned integers instead of "%d"
* Remove redundant function prototypes
* Use ssprintf instead of snprintf where appropriate
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6159 4a71c877-e1ca-e34f-864e-861f7616d084
* Const correctness
* Use "(unsigned )?int" instead of "[SU](D?WORD|BYTE)" where the size guarantee is not required
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6158 4a71c877-e1ca-e34f-864e-861f7616d084
* Implement hypot() and hypotf() on non-C99 systems
* Wherever the parameters to dirtyHypot() are signed: use hypotf() instead
* Move some variables in to a more local scope
* Merge the conditions of some nested if-statements
* Get rid of some stupidly named variables (tempx and tempy are ''not'' good variable names, the names should indicate ''what'' the variables contain, not for how long)
* Remove some unnecessary casting between float and [SU]DWORD
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6157 4a71c877-e1ca-e34f-864e-861f7616d084
* Const correctness
* Return as soon as we've got our result (rather than assigning to a temporary and returning only at the end of the function)
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6156 4a71c877-e1ca-e34f-864e-861f7616d084
* Change dirtyHypot()'s interface to match that of hypot() (i.e. specify the coordinates relative to the origin instead of another coordinate)
* Mark dirtyHpot() as deprecated in the Doxygen documentation and suggest to use hypot() or hypotf() instead (C99 functions for which I'll provide work arounds in math-help.h soon after this commit)
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6155 4a71c877-e1ca-e34f-864e-861f7616d084
* The lexers depend on the parser's headers so make sure to compile the parsers first
* Move a misplaced line-wrapping backslash in src/makefile.win32
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6153 4a71c877-e1ca-e34f-864e-861f7616d084
* aiexperience.[ch] was written by Troman and included in r609
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6151 4a71c877-e1ca-e34f-864e-861f7616d084
* Rewrite NETgetGameFlagsUnjoined such that it's not hardcoded for its `flag` parameter anymore
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6150 4a71c877-e1ca-e34f-864e-861f7616d084
Make sure to add the correct number of team widgets, instead of having to display MAX_PLAYERS amount.
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6148 4a71c877-e1ca-e34f-864e-861f7616d084
Do this because we cannot trust malloc()'s heaps to be intact at the time an exception handler gets called.
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6146 4a71c877-e1ca-e34f-864e-861f7616d084
Alliances were formed in a SP game that were not supposed to be formed as a byproduct of having game.alliance set to ALLIANCES_TEAMS in a skirmish/MP game.
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6140 4a71c877-e1ca-e34f-864e-861f7616d084
Thomas Frauendorfer. Make us test validity of system component when changing
propulsion, and also avoid crashing if current weapon mode is invalid. Pach
reviewed by Buginator.
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6139 4a71c877-e1ca-e34f-864e-861f7616d084
a structure, which has potentially one more weapon that this. Second and more serious issue is that
if a building is demolished, it will no longer be updated in regards to dead targets.
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6136 4a71c877-e1ca-e34f-864e-861f7616d084
Makes it easier to modify/change menu entries and such.
Should not affect code behavior at all.
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6122 4a71c877-e1ca-e34f-864e-861f7616d084
* Add support for decoding and displaying of OggTheora/Vorbis videos
* Change all references to *.rpl files to *.ogg files (and lower case them)
* Add a new menu (and config) option for selecting the size at which to display videos (1x (native), 2x, full screen)
This closes ticket:64 and ticket:46
Code changes are ticket:64 (patch by Gerard Krol, Giel van Schijndel and Buginator)
FMVs can be found at http://download.gna.org/warzone/videos/sequences_ogg.zip (for now at least)
Videos encoded by Angus Lees
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6119 4a71c877-e1ca-e34f-864e-861f7616d084
* Get rid of bCDPath and bHardPath which guarded the initialisation of aHardPath
* Remove seq_SetVideoPath which performed the initialisation of aHardPath
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6113 4a71c877-e1ca-e34f-864e-861f7616d084
* Use "bool" instead of "BOOL" for the return types of lib/sequence functions
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@6112 4a71c877-e1ca-e34f-864e-861f7616d084
Giel van Schijndel
Freddie Witherden
Buginator
Per Inge Mathisen