* modify createDroid, createFeature and createStruct to use a NULL pointer as failure notification rather than FALSE
* get rid of createStructFunc and removeStructFunc which where nothing more than fancy malloc and free wrappers
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1864 4a71c877-e1ca-e34f-864e-861f7616d084
* Fix a syntax error (missing brace)
* Code cleanup: put curly braces on their own line
* remove a copy&pasted switch statement, and merged it into the switch directly above (all case labels and break statements where _exactly_ the same, only the statements executed where different)
* Use #if 0;#endif for commenting out code instead of /*;*/
* move some vars in the most local scope where they're used
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1860 4a71c877-e1ca-e34f-864e-861f7616d084
This will cause many new asserts, but easier to track down bugs. To find if a bug is caused
by too early object destruction, use "--debug memory" and compare with pointers such as
"psObj-psDest" (one frequent offender in projectiles).
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1858 4a71c877-e1ca-e34f-864e-861f7616d084
* modify accessing a global var to using a set function instead
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1856 4a71c877-e1ca-e34f-864e-861f7616d084
* Mark some global pointers/vars for static linkage (the less global, and more local they are, the better!)
* Add include guards to some files
* Some code cleanup: braces on their own line
* loadFile2 now doesn't free memory it didn't allocate itself anymore
* Use decent assertion expressions for some asserts (e.g. !"string", so that debuggers actually display something more interesting than 'FALSE')
* Don't assert(pointed_to_data != 0xdddddddd) since that method of detecting usage of dangling pointers only works with MSVC, while MSVC's free() probably (i.e. if it is sane) implementation does this check itself already
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1855 4a71c877-e1ca-e34f-864e-861f7616d084
* Mark some global pointers/vars for static linkage (the less global, and more local they are, the better!)
* Some code cleanup: 4 spaces -> TAB, braces on their own line
* Don't `if (pointer != NULL) free(pointer);` since free(NULL) is very much legal as well (and more readable IMO)
* move some vars in the most local scope where they're used
* make ResearchRelease return void rather than BOOL, since all calling functions ignored its result; plus the function itself never returned anything else than TRUE
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1853 4a71c877-e1ca-e34f-864e-861f7616d084
expected that an oil derrick would always be placed on top of an oil feature.
This is not the case when loading games, however. In this case, the oil is gone.
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1847 4a71c877-e1ca-e34f-864e-861f7616d084
still assert, though. We need to figure out why it sometimes wants
to build derricks on tiles that do not have oil.
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1846 4a71c877-e1ca-e34f-864e-861f7616d084
* Declare vars at the beginning of the block
Hinted at the problem by vs2k5
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1843 4a71c877-e1ca-e34f-864e-861f7616d084
connectors, team colors (using a second UV layer). Not supported: animations of any kind.
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1840 4a71c877-e1ca-e34f-864e-861f7616d084
* Add explaining comments
* Remove some pieces of commented out code that only help us stand a better chance at winning the "Obfuscated C" contest
* Get rid of some copy&pasted code which only has minor differences, and use a more general of the two copies instead
* Remove armourDamage (held damage dealt to an object's armor) since it wasn't ever used
Cleanup part of patch #745 by Freddie Witherden <EvilGuru>
Plus additional modifications by myself
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1836 4a71c877-e1ca-e34f-864e-861f7616d084
* Remove some commented out lines
* One of these commented out pieces described lowering armor as a result of being shot; this however would result in high ROF weapons being overpowered (not to mention the code was so old it probably wouldn't compile)
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1834 4a71c877-e1ca-e34f-864e-861f7616d084
* Use "%zu" as format specifier to print out size_t types
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1833 4a71c877-e1ca-e34f-864e-861f7616d084
* This conditional compilation is controlled by WZ_NOSOUND (which replaces WZ_NOOGG)
* Remove an unneed inclusion from oggvorbis.h (track.h)
NOTE: This is currently integrated in none of the build systems
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1832 4a71c877-e1ca-e34f-864e-861f7616d084
* Create a dedicated function for conversion of ASCII characters into upper case: upcaseASCII
* Make HashStringIgnoreCase use upcaseASCII instead of an ugly bitmask hack which won't even work as expected on all strings!!
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1830 4a71c877-e1ca-e34f-864e-861f7616d084
* modify getDroidLevel to provide the functionality of cmdDroidLevel for command and sensor droids
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1827 4a71c877-e1ca-e34f-864e-861f7616d084
(I simply should have enabled my VIM XML validation script, doh!)
Patch by vs2k5
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1826 4a71c877-e1ca-e34f-864e-861f7616d084
* To make sure we still have the guarantee that a char is 8bit I've inserted a static assertion for this (CHAR_BIT == 8)
* Use exact length types for lobbyserver
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1821 4a71c877-e1ca-e34f-864e-861f7616d084
That is:
* Don't use a custom memory heap implementation anymore
* Remove all usages of HEAP code and replace it with malloc/free
NOTE: MacOSX projectfile probably requires an update
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1820 4a71c877-e1ca-e34f-864e-861f7616d084
* Replace use of heaps psDroidHeap, psStructHeap, psFeatureHeap and psGrpHeap with malloc/free
* Use decent assertion expressions for some asserts (e.g. !"string", so that debuggers actually display something more interesting than 'FALSE')
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1819 4a71c877-e1ca-e34f-864e-861f7616d084
* Replace use of heaps psStructFuncHeap and psFlagPosHeap with malloc/free
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1818 4a71c877-e1ca-e34f-864e-861f7616d084
* Use decent assertion expressions for some asserts (e.g. !"string", so that debuggers actually display something more interesting than 'FALSE')
git-svn-id: svn+ssh://svn.gna.org/svn/warzone/trunk@1815 4a71c877-e1ca-e34f-864e-861f7616d084
Giel van Schijndel
Ari Johnson
Per Inge Mathisen
Dennis Schridde
Gerard Krol