Document some bug/missing feature in the serializeAttributes tests.

(stringw arrays can't serialize to/from strings - that's ignored silently at the moment, not yet tested if/how it works in combination with xml-reader, but that one should or other tests would fail).


git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@5572 dfc29bdd-3216-0410-991c-e03cc46cb475
master
cutealien 2017-11-07 00:30:49 +00:00
parent 51172244ed
commit 7a87a77a8a
2 changed files with 11 additions and 2 deletions

View File

@ -318,6 +318,15 @@ bool stringSerialization(io::IFileSystem * fs)
, core::stringc(value).c_str(), core::stringc(value2).c_str(), i, attr->getAttributeName(i), __FILE__, __LINE__ );
return false;
}
else
{
// TODO: We can't catch yet if getAttributeAsString and setAttribute both change nothing
// Except if string returned is empty - which would be fine in some cases (0 pointers or if string was empty originally)
// But right now at least stringw arrays don't do stringSerialization which is a bug
//if ( value.empty() )
//return false;
}
}
attr->drop();

View File

@ -1,4 +1,4 @@
Tests finished. 2 tests of 2 passed.
Tests finished. 1 test of 1 passed.
Compiled as DEBUG
Test suite pass at GMT Fri Jul 8 21:06:13 2016
Test suite pass at GMT Tue Nov 7 00:00:50 2017