From 7a87a77a8ac310ffc6f6cd2cf6536db5d53f59c0 Mon Sep 17 00:00:00 2001 From: cutealien Date: Tue, 7 Nov 2017 00:30:49 +0000 Subject: [PATCH] Document some bug/missing feature in the serializeAttributes tests. (stringw arrays can't serialize to/from strings - that's ignored silently at the moment, not yet tested if/how it works in combination with xml-reader, but that one should or other tests would fail). git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@5572 dfc29bdd-3216-0410-991c-e03cc46cb475 --- tests/serializeAttributes.cpp | 9 +++++++++ tests/tests-last-passed-at.txt | 4 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/serializeAttributes.cpp b/tests/serializeAttributes.cpp index 5e8eea75..220666ac 100644 --- a/tests/serializeAttributes.cpp +++ b/tests/serializeAttributes.cpp @@ -318,6 +318,15 @@ bool stringSerialization(io::IFileSystem * fs) , core::stringc(value).c_str(), core::stringc(value2).c_str(), i, attr->getAttributeName(i), __FILE__, __LINE__ ); return false; } + else + { + // TODO: We can't catch yet if getAttributeAsString and setAttribute both change nothing + // Except if string returned is empty - which would be fine in some cases (0 pointers or if string was empty originally) + // But right now at least stringw arrays don't do stringSerialization which is a bug + //if ( value.empty() ) + //return false; + } + } attr->drop(); diff --git a/tests/tests-last-passed-at.txt b/tests/tests-last-passed-at.txt index b53b5189..ece44e99 100644 --- a/tests/tests-last-passed-at.txt +++ b/tests/tests-last-passed-at.txt @@ -1,4 +1,4 @@ -Tests finished. 2 tests of 2 passed. +Tests finished. 1 test of 1 passed. Compiled as DEBUG -Test suite pass at GMT Fri Jul 8 21:06:13 2016 +Test suite pass at GMT Tue Nov 7 00:00:50 2017