44a537e705
Right-clicking on the top of a shelf would place a legacy plantlike eggcorn. This was due to the storebox right-click override unconditionally calling `item_place_node` when placing an item against an inaccessible side of a storebox. The solution would be to call `item_place` instead, since that function has the logic to handle `place_as_item` correctly. However, this cannot be called from the storebox right-click override directly because `item_place` calls the `pointed_thing` `on_rightclick`, which would cause an infinite recursion. Solve this by refactoring the placement logic into a new `minetest.item_place_node_or_stack` which is called by `item_place`, as well as by the storebox right-click override when placing items.
========================================================================
\ /\
\ / \
/\ \ /\ |\ / / \ /\ |\ /
| \ | / \ | \ / | / \ | \ /
| \ | | | | | |__ | | | | / |__
\ \/ | | | | | \ / | | |/ |
\ \ / | / \ \ / \ / |\ \
\ \/ |/ \ \/ \/ | \ \
========================================================================
NodeCore - Minetest's top original voxel game
about emergent mechanics and exploration
------------------------------------------------------------------------
A surreal dream-world where everything is possible but nothing is easy.
Peaceful and Zen. Brutally obstinate. Prepare to unlearn everything
you thought you knew about voxel sandbox games.
Visit the Minetest ContentDB Listing (below) for more details.
------------------------------------------------------------------------
NodeCore is (C)2018-2021 by Aaron Suen <warr1024@gmail.com>
MIT License (http://www.opensource.org/licenses/MIT)
See included LICENSE file for full details and credits
Minetest ContentDB Listing:
https://content.minetest.net/packages/Warr1024/nodecore/
GitLab:
https://gitlab.com/sztest/nodecore
Chat Networks (all bridged):
Discord:
https://discord.gg/NNYeF6f
Matrix:
#nodecore:matrix.org
IRC:
#nodecore on irc.libera.chat
Semi-Unofficial Wiki:
https://nodecore.mine.nu/
Minetest Forum Topic:
https://forum.minetest.net/viewtopic.php?t=24857
------------------------------------------------------------------------
========================================================================