The way MT serializes this data is fundamentally unsafe now since 5.1 or
so, and will randomly break due to random box positions. One day it
works fine and the next day the server crashes on the same apparent
link operation. All because the itemstack data can likely not handle
\000 data during either serialization or deserialization. The outcome
is 5, or even 4 bytes returned from deserialization, and thus a server
crash.
This is BW compatible. Old connector tools will be functional and appear
as linked in the tooltip, but there will be an error to the user telling
them to "start" the link again first. No box is broken - this is only
affecting itemstacks.
The alpha values here are now no longer used. They are roughly the same
as the original value in the alpha channel, so this looks the same from
my perspective.
This moves review into a separate permission, aside from "server".
The benefit is that we can grant this to more people without the
need to pass out "server" privs, which has a lot more powers than
needeed.
This doesn't grant noclip. This needs to be done separately. Scoring
will be disabled for those with the review priv.
Since we converted these tools into craftitems, to allow them to
stack, they have been missing from the tools tab. Explicitly insert
them so builders can obtain them easily again.
Instead of ANAND's suggestion to put this function in the `player` API,
I feel it belongs in the `boxes` API instead, other than that it's
mostly similar to his MR#18.
This moves the perk code so it can handle offline players
easily. Granted perks are immediate if the player is online
and otherwise granted at login. This avoids any of the issues
with offline players.
We were accidentally shadowing `nodes` which broke the texture
retrieval call, but worse, we never searched for placeholder
nodes in the search filter.
Boxes need to be tested. Untested boxes can not be submitted.
For small edits, re-testing isn't required (<150sec). Lots of
messaging to the builder as well to make sure it doesn't go
unnoticed.
These were previously filtered out. Unfortunately now there's some
awkward emtpy lines in various places, but, I prefer having empty
lines show since that makes typing much simpler.
This really breaks badly. Too many untranslatable characters that
completely break things. These are meant to be technical and postion
strings are not translatable either. Revert.
