fix link

.github/workflows/luacheck.yml

@@ -0,0 +1,18 @@
+
+name: luacheck
+
+on: [push, pull_request]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: apt
+      run: sudo apt-get install -y luarocks
+    - name: luacheck install
+      run: luarocks install --local luacheck
+    - name: luacheck run
+      run: $HOME/.luarocks/bin/luacheck ./

.luacheckrc

@@ -0,0 +1,25 @@
+unused_args = false
+allow_defined_top = true
+
+exclude_files = {".luacheckrc"}
+
+globals = {
+    "minetest", "core",
+
+    --mod provided
+    "abriglass",
+}
+
+read_globals = {
+    string = {fields = {"split"}},
+    table = {fields = {"copy", "getn"}},
+
+    --luac
+    "math", "table",
+
+    -- Builtin
+    "vector", "ItemStack", "dump", "DIR_DELIM", "VoxelArea", "Settings", "PcgRandom", "VoxelManip", "PseudoRandom",
+
+    --mod produced
+    "default",
+}

README.md

@@ -38,4 +38,4 @@ Textures for this mod are released under CC BY-SA 4.0 (https://creativecommons.o
 Recommended Additions
 -----------------------
 
-- [abriflame](https://github.com/Ezhh/abriflame) allows coloured flames to be lit on coloured glass nodes.
+- [abriflame](https://github.com/mt-mods/abriflame) allows coloured flames to be lit on coloured glass nodes.

crafting.lua

@@ -15,7 +15,6 @@ local plain_colors = {
 	"green", "blue", "red", "yellow",
 }
 
-local i
 for i in ipairs(plain_colors) do
 	local name = plain_colors[i]
 	local nodesuffix = 'glass_light_'..name
@@ -38,7 +37,7 @@ end
 
 -- undecorated coloured glass recipes
 local dye_list = {
-	{"black", "black",}, 
+	{"black", "black",},
 	{"blue", "blue",},
 	{"cyan", "cyan",},
 	{"green", "green",},
@@ -46,7 +45,7 @@ local dye_list = {
 	{"orange", "orange",},
 	{"purple", "violet",},
 	{"red", "red",},
-	{"yellow", "yellow",}, 
+	{"yellow", "yellow",},
 	{"frosted", "white",},
 }
 
@@ -137,7 +136,15 @@ minetest.register_craft({
 
 
 -- cooking recipes
-local cook_list = { "stainedglass_pattern01", "stainedglass_pattern02", "stainedglass_pattern03", "stainedglass_pattern04", "stainedglass_pattern05", "stainedglass_tiles_dark", "stainedglass_tiles_pale"}
+local cook_list = {
+	"stainedglass_pattern01",
+	"stainedglass_pattern02",
+	"stainedglass_pattern03",
+	"stainedglass_pattern04",
+	"stainedglass_pattern05",
+	"stainedglass_tiles_dark",
+	"stainedglass_tiles_pale"
+}
 
 for i = 1, #cook_list do
 	local name = cook_list[i]

depends.txt

@@ -1,2 +0,0 @@
-default
-dye

description.txt

@@ -1 +0,0 @@
-Adds coloured glass, patterned stained glass, glass lights and one way windows.

init.lua

@@ -4,3 +4,5 @@ abriglass = {}
 
 dofile(modpath.."nodes.lua")
 dofile(modpath.."crafting.lua")
+
+abriglass.init = true

mod.conf

@@ -1 +1,3 @@
-name = abriglass
+name = abriglass
+depends = default, dye
+description = Adds coloured glass, patterned stained glass, glass lights and one way windows.

nodes.lua

@@ -2,9 +2,9 @@
 -- undecorated coloured glass, all using plain glass texture
 local glass_list = {
 	{"black", "Darkened", "292421",}, {"blue", "Blue", "0000FF",},
-	{"cyan", "Cyan", "00FFFF",}, {"green", "Green", "00FF00",}, 
-	{"magenta", "Magenta", "FF00FF",}, {"orange", "Orange", "FF6103",}, 
-	{"purple", "Purple", "800080",}, {"red", "Red", "FF0000",}, 
+	{"cyan", "Cyan", "00FFFF",}, {"green", "Green", "00FF00",},
+	{"magenta", "Magenta", "FF00FF",}, {"orange", "Orange", "FF6103",},
+	{"purple", "Purple", "800080",}, {"red", "Red", "FF0000",},
 	{"yellow", "Yellow", "FFFF00",}, {"frosted", "Frosted", "FFFFFF",}
 }
 
@@ -17,7 +17,7 @@ for i in ipairs(glass_list) do
 		description = description.." Glass",
 		tiles = {"abriglass_plainglass.png^[colorize:#"..colour..":122"},
 		groups = {cracky = 3},
-		use_texture_alpha = true,
+		use_texture_alpha = "blend",
 		sunlight_propagates = true,
 		light_source = 4,
 		drawtype = "glasslike",
@@ -32,7 +32,7 @@ minetest.register_node("abriglass:clear_glass", {
 	description = "Clear Glass",
 	tiles = {"abriglass_clearglass.png"},
 	groups = {cracky = 3},
-	use_texture_alpha = true,
+	use_texture_alpha = "blend",
 	sunlight_propagates = true,
 	paramtype = "light",
 	drawtype = "glasslike",
@@ -57,7 +57,7 @@ for i in ipairs(light_list) do
 		description = description.. "Glass Light",
 		tiles = {"abriglass_" ..image.. ".png"},
 		groups = {cracky = 3},
-		use_texture_alpha = true,
+		use_texture_alpha = "blend",
 		sunlight_propagates = true,
 		light_source = 14,
 		drawtype = "glasslike",
@@ -87,7 +87,7 @@ for i in ipairs(pattern_list) do
 		description = description,
 		tiles = {"abriglass_"..image..".png"},
 		groups = {cracky = 3},
-		use_texture_alpha = true,
+		use_texture_alpha = "blend",
 		sunlight_propagates = true,
 		light_source = 5,
 		drawtype = "glasslike",
@@ -124,7 +124,7 @@ for i in ipairs(port_list) do
 				 "default_"..name.. ".png", -- left
 				 "abriglass_porthole_"..name..".png", -- back
 				 "abriglass_porthole_"..name..".png", -- front
-				 }, 
+				 },
 		is_ground_content = false,
 		sunlight_propagates = true,
 	})
@@ -164,7 +164,7 @@ for i in ipairs(oneway_list) do
 				 "abriglass_oneway_plain_glass.png", -- left
 				 "abriglass_"..image1, -- back
 				 image2, -- front
-				 }, 
+				 },
 		is_ground_content = false,
 		sunlight_propagates = true,
 		inventory_image = minetest.inventorycube("abriglass_"..image1)
@@ -194,7 +194,7 @@ minetest.register_node("abriglass:ghost_crystal", {
 	tiles = {"abriglass_ghost_crystal.png"},
 	wield_image = "abriglass_ghost_crystal_wield.png",
 	groups = {cracky = 3},
-	use_texture_alpha = true,
+	use_texture_alpha = "blend",
 	sunlight_propagates = true,
 	light_source = 14,
 	drawtype = "glasslike",
@@ -206,9 +206,9 @@ minetest.register_node("abriglass:ghost_crystal", {
 -- hidden light node
 minetest.register_node("abriglass:hidden_light", {
 	description = "Hidden Light",
-	tiles = {"abriglass_oneway_plain_glass.png"}, 
+	tiles = {"abriglass_oneway_plain_glass.png"},
 	groups = {cracky = 3, not_in_creative_inventory=1},
-	use_texture_alpha = true,
+	use_texture_alpha = "blend",
 	sunlight_propagates = true,
 	walkable = false,
 	light_source = 7,