jp9000
3699209ce4
libobs: Pair encoders only when output actually starts
Normally, paired encoders are unpaired when they stop. However, if the pairing occurs before the encoders actually start, and the encoders never actually end up starting, they are never unpaired, and that pairing stays with them until the next time an output is started up again. That in turn can cause an output that uses one of the encoders but not the other to not function correctly, and neither properly "start" nor stop because the data is queued continually in the interleaved packet array. For example, let's say there are two outputs, two video encoders, and one audio encoder. This can be reproduced by using advanced output mode and making the two outputs use separate video encoders while sharing track 1's audio encoder. If you start up the stream output first and it fails to fully connect for whatever reason (bad server, bad stream key, etc), then you start up the recording output, the recording output will appear to be running, but will not stop when you hit "stop recording". It will stay perpetually on "stopping recording" and will get stuck that way. This is because when the streaming output started, the streaming output would initially pair video encoder A with audio encoder A before the encoders actually fully started up (as the encoders do not fully start up until a connection is successfully made), and when the recording output starts up after that disconnection, audio encoder A will wait for video encoder A rather than video encoder B because that pairing was never actually cleared. So, instead of pairing encoders when the output starts, wait until the encoders themselves are being started and then pair the encoders at that point in time. This ensures that the encoders start up and will clear their pairing when no longer in use.
OBS Studio <https://obsproject.com> =================================== .. image:: https://travis-ci.org/obsproject/obs-studio.svg?branch=master :alt: OBS Studio Build Status - Travis CI :target: https://travis-ci.org/obsproject/obs-studio .. image:: https://ci.appveyor.com/api/projects/status/github/obsproject/obs-studio?branch=master&svg=true :alt: OBS Studio Build Status - AppVeyor CI :target: https://ci.appveyor.com/project/jp9000/obs-studio/branch/master .. image:: https://dev.azure.com/obsjim/obsjim/_apis/build/status/obsproject.obs-studio?branchName=master :alt: OBS Studio Build Status - Azure Pipelines :target: https://dev.azure.com/obsjim/obsjim/_build/latest?definitionId=1&branchName=master .. image:: https://discordapp.com/api/guilds/348973006581923840/widget.png?style=shield :alt: OBS Studio Discord Server :target: https://obsproject.com/discord What is OBS Studio? ------------------- OBS Studio is software designed for capturing, compositing, encoding, recording, and streaming video content, efficiently. It's distributed under the GNU General Public License v2 (or any later version) - see the accompanying COPYING file for more details. Quick Links ----------- - Website: https://obsproject.com - Help/Documentation/Guides: https://github.com/obsproject/obs-studio/wiki - Forums: https://obsproject.com/forum/ - Build Instructions: https://github.com/obsproject/obs-studio/wiki/Install-Instructions - Developer/API Documentation: https://obsproject.com/docs - Donating/backing/sponsoring: https://obsproject.com/contribute - Bug Tracker: https://obsproject.com/mantis/ (Note: The bug tracker is linked to forum accounts. To use the bug tracker, log in to a forum account) Contributing ------------ - If you would like to help fund or sponsor the project, you can do so via `Patreon <https://www.patreon.com/obsproject>`_, `OpenCollective <https://opencollective.com/obsproject>`_, or `PayPal <https://www.paypal.me/obsproject>`_. See our `contribute page <https://obsproject.com/contribute>`_ for more information. - If you wish to contribute code to the project, please make sure to read the coding and commit guidelines: https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst - Developer/API documentation can be found here: https://obsproject.com/docs - If you wish to contribute translations, do not submit pull requests. Instead, please use Crowdin. For more information read this thread: https://obsproject.com/forum/threads/how-to-contribute-translations-for-obs.16327/ - Other ways to contribute are by helping people out with support on our forums or in our community chat. Please limit support to topics you fully understand -- bad advice is worse than no advice. When it comes to something that you don't fully know or understand, please defer to the official help or official channels.
Description
Languages
C
56%
C++
36.8%
CMake
3%
Objective-C++
1.5%
Objective-C
1.3%
Other
1.4%