Commit Graph

137 Commits (737fd8256e9262625c1163ee29f147bd3e5cdeda)

Author SHA1 Message Date
Anthony Forsberg 737fd8256e cleanup 2017-02-07 20:26:07 -05:00
Anthony Forsberg 360732cdcc Requirements update, setup changes 2017-02-07 20:23:25 -05:00
Anthony Forsberg fcd7526d5c Checks and alternative values added for singles 2017-01-28 08:23:31 -05:00
Anthony Forsberg ce27187c87 init needed to import patch 2017-01-28 06:19:06 -05:00
Anthony Forsberg 88107f7538 Fixes #100 and possibly #99
Patches Requests if Python version is below 3.6.0 to fix a quirk in
httplib relating to utf-8 headers.

Also tracks are now sanitized before tagging.
2017-01-28 06:12:21 -05:00
Anthony Forsberg 370da98e21 Refined the regex, no need to remove offending characters now 2017-01-16 21:14:00 -05:00
Anthony Forsberg 6dc73cf5eb version bump, readme correction 2017-01-16 16:45:46 -05:00
Anthony Forsberg 1e572a7ad3 JS dictionary can contain strings with ; in them 2017-01-16 16:41:26 -05:00
Anthony Forsberg feb6d93bb9 Fixes #95
Fixed the incomplete file issue due to not understanding Mutagens
tagging process.

Also added in user_agent and requests session, the user-agent because
its proper and session because it increases performance slightly by
using keep-alive by default.
2017-01-13 14:15:42 -05:00
Anthony Forsberg c74e82ba96 Changes that I should not have merged from master into 0.0.7 2017-01-12 19:36:21 -05:00
Anthony Forsberg abf0dd261b Merge 0.0.7 (#94)
* Preliminary 0.0.7 changes

Moved to a new album/track data parser using demjson.

Slimit and Ply are no longer required.

Some basic spelling corrections and consistency changes.

Function Annotation, return types, and docstrings added.

* Initial commit for the Issue Template

* Fleshed out the issue template

* Switched to rst (oops), reformatted accordingly

* Update ISSUE_TEMPLATE.rst

* Moved CONTRIBUTING to the hidden .github directory

* No longer trips up on unavailable tracks in an album

* Much more robust file integrity checking, session file support.

Multi-step process in making sure files are downloaded and encoded
properly.

Bandcamp-dl will now attempt to search for a not.finished file and if it
is found load that sessions arguments and resume operation form where it
left off.

* Improve download status/progress messages

Made the download progress and status messages neater, no more multiple
progress bars and lines of status messages.

* Final 0.0.7 changes

Setup imports for distribution again.

Reformatted docstrings.

Clarified choices in partial download dialog.

Updated changelog.

Updated manifest.

Updated readme.
2017-01-12 19:25:43 -05:00
Anthony Forsberg 0176249237 Fixes #95 2017-01-12 19:20:52 -05:00
Anthony Forsberg 98ccac604a Bugfix update prep 2017-01-09 20:31:08 -05:00
Olivier Aubert 5a06c86b61 Specify filename encoding (#93)
Else python will try to encode accented filenames with ascii codec, which will fail.
2017-01-09 20:20:08 -05:00
Anthony Forsberg 2815bd3e19 Update README.rst 2017-01-05 14:09:53 -05:00
Anthony Forsberg d8ce58e66d Revert "Preliminary 0.0.7 changes"
This reverts commit 8cc97905a7.
2017-01-04 14:08:56 -05:00
Anthony Forsberg 8cc97905a7 Preliminary 0.0.7 changes
Moved to a new album/track data parser using demjson.

Slimit and Ply are no longer required.

Some basic spelling corrections and consistency changes.

Function Annotation, return types, and docstrings added.
2017-01-04 14:07:53 -05:00
Anthony Forsberg 8429426760 Merge pull request #82 from iheanyi/0.0.6
Proper source install instructions, new options.
2016-12-30 15:50:32 -05:00
Anthony Forsberg 5f234ce38a Proper source install instructions, new options. 2016-12-30 15:50:04 -05:00
Anthony Forsberg 14bc45cc98 Merge pull request #81 from iheanyi/0.0.6
Version numbering
2016-12-30 10:40:18 -05:00
Anthony Forsberg e3bb0acff2 Version numbering 2016-12-30 10:39:53 -05:00
Anthony Forsberg 2c0ab7e3ec Merge pull request #80 from iheanyi/0.0.6
Another small python 2.7.12 update, hopefully the last
2016-12-30 09:14:24 -05:00
Anthony Forsberg 7a9ae45657 Another small python 2.7.12 update, hopefully the last 2016-12-30 09:13:55 -05:00
Anthony Forsberg d5a7d1d738 Merge pull request #79 from iheanyi/0.0.6
0.0.6 - Merge
2016-12-30 09:06:23 -05:00
Anthony Forsberg 8553d95128 Important note for future purposes 2016-12-30 09:00:55 -05:00
Anthony Forsberg 542ab1aec0 Tiny change to support Python 2.7.12 2016-12-30 08:58:50 -05:00
Anthony Forsberg 887ea3c2bc v0.0.6 Changelog update 2016-12-30 08:52:22 -05:00
Anthony Forsberg d3fdd798bf --no-art option, mutagen cleanup, removed bad lyric code.
Added the option to skip grabbing album art.

Removed the lyric grabbing code for now as it seems that if its
available its already embedded

Organized the mutagen imports and encoding.
2016-12-30 08:38:23 -05:00
Anthony Forsberg ed5132bdd0 Version correction 2016-12-27 18:25:55 -05:00
Anthony Forsberg 6ba85c44fb Lyrics saved as USTL tag inside MP3
Modified/Merged @sun2rise's PR, was having issues merging the actual PR
due to the repo being gone (and I'm bad at git)

Had to make some changes to the imports as Mutagen has had some changes.
2016-12-27 18:25:21 -05:00
Anthony Forsberg 02ddf5ba04 Travis CI config
Still need to write some tests.
2016-12-19 13:00:13 -05:00
Anthony Forsberg 33e5053c52 Readme update 2016-12-19 11:46:39 -05:00
Anthony Forsberg 97d6817fb0 Setup changes, PyPI, manifest
New version up on PyPI had to make some changes to setup.
2016-12-19 11:41:10 -05:00
Anthony Forsberg 587f270e96 Merge pull request #73 from iheanyi/bandcamp-dl-py2
Merging branch with master
2016-12-19 09:54:40 -05:00
Anthony Forsberg f157a7fe7d Refactor, original scheme 2016-12-18 12:49:34 -05:00
Anthony Forsberg c5f2f2b95c RST Format 2016-12-16 14:11:01 -05:00
Anthony Forsberg eac0c43fc5 RST Format 2016-12-16 14:10:34 -05:00
Anthony Forsberg 0c76ae7112 RST formatting 2016-12-16 14:09:59 -05:00
Anthony Forsberg 671fb32a51 Fleshing out the repo
Some nice additions to the repo + more PyPI setup.
2016-12-15 22:10:00 -05:00
Anthony Forsberg 02858b19d4 Tweaks for PyPI
requirements.txt is now concrete and setup.py is abstract as it should
be.
2016-12-15 21:18:16 -05:00
Anthony Forsberg 7df0b81556 Public Domain -> Unlicense 2016-12-15 21:09:47 -05:00
Anthony Forsberg 3c3f2f230e Updated setup.py, fixed lingering differences
setup.py now has both Python tags.

Fixed some lingering spacing differences.
2016-12-15 20:50:37 -05:00
Anthony Forsberg a8ebb47e3e Big update, see description.
Refactored to match Python 3 branch.

Switched to a README.rst (for PyPI support) spell checked, updated
information, removed IRC link in favor of Discord (No one was ever in
the IRC channel)

Updated deps, requirements, and setup.py.

Now using the latest versions of the required dependencies.
Note: May cause lextab.py/yacctab.py warnings, they are harmless. If the
warning are annoying delete those two files in site-packages/Slimit
(That are generated anyway)

Updated code, using latest supported syntax for everything possible
while still supporting Python 2.7.x.

Currently code is 1:1 with the Python 3 branch.
2016-12-15 20:28:24 -05:00
Anthony Forsberg 5ae6aa5740 Merge pull request #63 from Bendito999/master
ID3 Data Windows Explorer Compatibility
2016-12-11 16:46:02 -05:00
Anthony Forsberg 510e315599 Update README.md
2.7+ -> 2.7.x (Clarifies that is should be used under a Python 2 version not Python 2/3)
Spelling.
2016-12-11 08:40:51 -05:00
Iheanyi Ekechukwu 2f33b15d8a Merge pull request #64 from szabgab/patch-1
fix typo
2016-10-17 10:04:15 -04:00
Gabor Szabo 1555546031 fix typo 2016-09-07 10:32:58 +03:00
Bendito999 9eac9ac067 ID3 Data Windows Explorer Compatibility
Windows Explorer and Media Player cannot read ID3v2 data without first having ID3v1 data present. This makes it necessary to first enable ID3v1 if it was not already enabled on the files (which apparently Bandcamp does not)

It's probably easy to miss this on any reasonable media player or Linux ;)

More syntax info from 
http://mutagen.readthedocs.org/en/latest/api/id3.html#mutagen.id3.ID3.save

Original solution from post on https://code.google.com/p/mutagen/wiki/Tutorial

>Comment by jehoshu...@gmail.com, Oct 4, 2011
>After many hours . . .
>I discovered why on save() the information disappears in Windows Explorer and Media Player . . .
>. . . Windows Explorer and Media Player only read, and mutagen does NOT write, ID3v1 tags!
>And as far as I can tell from the LIMITED documentation, mutagen will READ BUT NOT WRITE ID3v1  tags.
>I further discovered, while playing with WINAMP, that it is possible to have BOTH ID3v1 and ID3v2 tags in a file, BUT Windows Explorer and Media Player require the ID3v1 tags to come first!
>But there's no way to explicitly ensure that mutagen follows this requirement.
>Does anybody know ID3v1 well enough to dive into the source code and fix this?
>I'm using Windows 7, Python 2.7, Mutagen 1.20. I really hope this helps someone avoid spending painful amounts time!
2016-09-04 15:51:38 -04:00
Iheanyi Ekechukwu 50b0a7781a Merge pull request #51 from Mixbo/master
Changed hardcoded python to env PATH
2016-04-01 10:37:34 -04:00
Iheanyi Ekechukwu 6c0d08a48d Merge pull request #52 from Mixbo/encoding
Encoding
2016-03-28 16:09:57 -07:00