Nick Terrell
9889bca530
[FSE] Fix division by zero
...
When the primary normalization method fails, and
`(1 << tableLog) == (maxSymbolValue + 1)`, and every symbol gets assigned
normalized weight 1 or -1 in the first loop, then the next division can
raise `SIGFPE`.
2018-07-27 17:30:03 -07:00
Nick Terrell
3abfbee215
Merge pull request #1250 from jennifermliu/fastCover
...
Add Fast Cover Dictionary Builder
2018-07-27 15:11:57 -07:00
Jennifer Liu
49b398e93f
Use same param after optimizing cover and fastCover and record k and d for benchmarking
2018-07-27 13:39:19 -07:00
Jennifer Liu
759c543312
Rerun cover and fastCover with optimized values
2018-07-26 19:03:01 -07:00
Jennifer Liu
3d7941ce41
Benchmark different f values
2018-07-26 16:24:13 -07:00
Nick Terrell
7974628587
Merge pull request #1252 from GeorgeLu97/bench-quiet-display-fix
...
Fixes bug
2018-07-26 16:12:15 -07:00
George Lu
09ccd977c3
no zero
2018-07-26 15:17:58 -07:00
Jennifer Liu
3b163e0b5b
Add array to keep track of frequency within active segment, fix malloc bug, update benchmarking result
2018-07-26 13:53:13 -07:00
Jennifer Liu
2333ecb173
Allow d=6
2018-07-25 18:10:09 -07:00
Jennifer Liu
1e85f314d8
Benchmark fast cover optimize vs k=200
2018-07-25 17:53:38 -07:00
Jennifer Liu
d1fc507ef9
Initial benchmarking result for fastCover
2018-07-25 17:05:54 -07:00
Jennifer Liu
f5407e398a
Make hash value const
2018-07-25 16:54:08 -07:00
Jennifer Liu
7f3f70f766
Add Fast Cover Dictionary Builder
2018-07-25 16:34:07 -07:00
Nick Terrell
77068a8447
Merge pull request #1246 from jennifermliu/benchmark
...
Benchmark dictionary builders
2018-07-20 18:09:31 -07:00
Jennifer Liu
b6c5d4982c
Minor fix
2018-07-20 17:41:22 -07:00
Jennifer Liu
71e767ac09
Refactoring and benchmark without dictionary
2018-07-20 17:03:47 -07:00
Jennifer Liu
470c8d42f4
Benchmark dictionary builders
2018-07-20 11:32:39 -07:00
Nick Terrell
2e47865d7d
Merge pull request #1245 from terrelln/disable-arm
...
Revert "attempt to re-enable arm64 tests"
2018-07-19 15:32:53 -07:00
Nick Terrell
5624f3f1ea
Revert "attempt to re-enable arm64 tests"
...
This reverts commit 9c277f137c
.
2018-07-19 14:35:27 -07:00
Nick Terrell
4d1ad5cdb2
Merge pull request #1238 from jennifermliu/random
...
Add random dictionary builder
2018-07-19 13:52:15 -07:00
Jennifer Liu
0c5eaef248
Update Makefile
2018-07-19 13:44:27 -07:00
Jennifer Liu
5bb46a898e
Rename cleanup
2018-07-18 12:15:49 -07:00
Jennifer Liu
52e7cf0e40
Add cleanup to trainfromFiles and move RANDOM_segment_t declaration
2018-07-18 10:40:13 -07:00
Yann Collet
effa84c8d1
Merge pull request #1230 from terrelln/train-out
...
zstdcli: Allow -o before --train
2018-07-18 16:34:10 +02:00
Yann Collet
6e490a2f09
Merge pull request #1237 from terrelln/init-cstream-adv
...
Set requestedParams in ZSTD_initCStream*()
2018-07-18 16:33:30 +02:00
Yann Collet
37da48986b
Merge pull request #1242 from facebook/mingw_traces
...
zstdmt debug traces compatibles with mingw
2018-07-18 12:23:07 +02:00
Yann Collet
545bd3dd01
Merge pull request #1244 from terrelln/ferror
...
fileio: Error in compression on read errors
2018-07-18 12:22:41 +02:00
Jennifer Liu
ce09fb723d
Update freeSampleInfo
2018-07-17 16:13:40 -07:00
Jennifer Liu
896ff0644a
Fix deallocation problem and add documentation
2018-07-17 16:01:44 -07:00
Nick Terrell
4e706d7f2c
fileio: Error in compression on read errors
...
We can write a corrupted file if the input file errors during a read.
We should return a non-zero error code in this case.
2018-07-17 15:26:30 -07:00
Jennifer Liu
e6fe405838
Make test PHONY target
2018-07-17 12:42:53 -07:00
Jennifer Liu
49acfaeaec
Move file loading functions to new file for access by benchmarking tool
2018-07-17 12:35:09 -07:00
cyan4973
53e1f0504e
zstdmt debug traces compatibles with mingw
...
since mingw does not have `sys/times.h`,
remove this path when detecting mingw compilation.
2018-07-17 14:39:44 +02:00
Jennifer Liu
4d32339b75
Remove CLevel cli option which was accidentally added back in the last commit
2018-07-16 18:59:18 -07:00
Jennifer Liu
1f7fa5cdd6
Fix spacing and Edit Makefile (now run with make instead of make run)
2018-07-16 16:31:59 -07:00
Jennifer Liu
b5806d33db
Refactor RANDOM
2018-07-16 16:03:04 -07:00
Nick Terrell
58b8219475
zstdcli: Allow -o before --train
...
Only set the default value if `outFileName` is unset.
Fixes #1227 .
2018-07-16 12:45:34 -07:00
Yann Collet
abc02e08ff
Merge pull request #1234 from codecat/add-premake
...
Added premake4/GENie script to contrib folder
2018-07-16 03:26:58 -07:00
Yann Collet
7608c67d7b
Merge pull request #1233 from terrelln/doc-fiz
...
Small fixes to zstd specification
2018-07-16 03:14:12 -07:00
Codecat
044cd81ce6
Fix wrong conditions
2018-07-14 12:34:03 +02:00
Codecat
1a61bdb9c0
Update zstd.lua
2018-07-14 12:27:42 +02:00
Jennifer Liu
0e5fbc10fa
Update README
2018-07-13 17:41:09 -07:00
Jennifer Liu
31731df4da
Remove clevel and update documentation
2018-07-13 17:38:53 -07:00
Jennifer Liu
a23a3b95f9
Add random dictionary builder
2018-07-13 16:05:14 -07:00
Nick Terrell
45821fac0c
Merge pull request #1225 from jennifermliu/dev
...
Split samples when building dictionary for COVER
2018-07-13 13:26:15 -07:00
Nick Terrell
6d222c437c
Set requestedParams in ZSTD_initCStream*()
...
The correct parameters are used once, but once `ZSTD_resetCStream()` is
called the default parameters (level 3) are used. Fix this by setting
`requestedParams` in the `ZSTD_initCStream*()` functions.
The added tests both fail before this patch and pass after.
2018-07-12 18:35:55 -07:00
Nick Terrell
aa2415402d
Merge pull request #1235 from ldv-alt/dev
...
tests: use /dev/zero instead of /dev/random on all systems except GNU/Hurd
2018-07-12 16:56:54 -07:00
Jennifer Liu
612b346ed5
Add explanation for split=100
2018-07-11 15:50:28 -07:00
Codecat
23d77c531e
Added premake4/GENie script to contrib folder
2018-07-11 18:02:18 +02:00
Dmitry V. Levin
7ca12a1455
tests: use /dev/zero instead of /dev/random on all systems except GNU/Hurd
...
https://github.com/facebook/zstd/pull/1124 broke the test suite
on Linux. Looks like GNU/Hurd is the only operating system where
/dev/random is available for writing by unprivileged processes.
https://github.com/facebook/zstd/pull/1222 reverted the change
introduced by https://github.com/facebook/zstd/pull/1124 for OpenBSD
only, other operating systems need that change to be reverted, too.
Fixes: 2dde9d5aba
("Write to /dev/random for test")
Complements: 276988f794
("OpenBSD is unable to write to /dev/zero")
2018-07-11 12:41:50 +00:00