Improve coverage. (#4363)

master
PJ Hampton 2017-07-18 16:56:43 +01:00 committed by Brian Stoner
parent b082c3013e
commit d5129df6e4
2 changed files with 9 additions and 2 deletions

View File

@ -11,11 +11,16 @@ my @triggers = ('timer', 'countdown', 'count down', 'alarm', 'reminder');
# Triggers that are vaild, but not stripped from the resulting query
my @nonStrippedTriggers = qw(minutes mins seconds secs hours hrs);
# Triggers that are valid in start only
my @startTriggers = qw(start begin set run);
my @baseTriggers = qw(start begin set run);
my @startTriggers = ();
# creates 'start a', 'begin a'
map { push(@startTriggers, "$_ a") } @baseTriggers;
push(@startTriggers, @baseTriggers);
# Beautifies the trigger can be appended in front/back of trigger
my @beautifierTriggers = qw(online);
#Joins the Timer Value
my @joiners = qw(for on at with);
my @joiners = qw(for on at to with);
# StartEndTriggers to trigger on nonStrippedTriggers, startTriggers, beautifierTriggers and triggers
my @triggersStartEnd = (@triggers, @nonStrippedTriggers, @startTriggers, @beautifierTriggers);
# Ambigous triggers which should not give Timer IA

View File

@ -102,6 +102,8 @@ ddg_goodie_test(
'20 mins' => build_test('1200'),
'timer 20 minutes' => build_test('1200'),
'timer 60 minutes' => build_test('3600'),
'start a timer for 20 minutes' => build_test('1200'),
'set a timer to 60 minutes' => build_test('3600'),
# Should not trigger
'start 30 minutes for timer' => undef,
'run with timer' => undef,