From d5129df6e42bc35ec1a8369deb6537cea2be9c22 Mon Sep 17 00:00:00 2001 From: PJ Hampton Date: Tue, 18 Jul 2017 16:56:43 +0100 Subject: [PATCH] Improve coverage. (#4363) --- lib/DDG/Goodie/Timer.pm | 9 +++++++-- t/Timer.t | 2 ++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/DDG/Goodie/Timer.pm b/lib/DDG/Goodie/Timer.pm index 4aeda2cda..a2319f19d 100644 --- a/lib/DDG/Goodie/Timer.pm +++ b/lib/DDG/Goodie/Timer.pm @@ -11,11 +11,16 @@ my @triggers = ('timer', 'countdown', 'count down', 'alarm', 'reminder'); # Triggers that are vaild, but not stripped from the resulting query my @nonStrippedTriggers = qw(minutes mins seconds secs hours hrs); # Triggers that are valid in start only -my @startTriggers = qw(start begin set run); +my @baseTriggers = qw(start begin set run); +my @startTriggers = (); +# creates 'start a', 'begin a' +map { push(@startTriggers, "$_ a") } @baseTriggers; +push(@startTriggers, @baseTriggers); + # Beautifies the trigger can be appended in front/back of trigger my @beautifierTriggers = qw(online); #Joins the Timer Value -my @joiners = qw(for on at with); +my @joiners = qw(for on at to with); # StartEndTriggers to trigger on nonStrippedTriggers, startTriggers, beautifierTriggers and triggers my @triggersStartEnd = (@triggers, @nonStrippedTriggers, @startTriggers, @beautifierTriggers); # Ambigous triggers which should not give Timer IA diff --git a/t/Timer.t b/t/Timer.t index 2ff20274a..7b4f0d5c1 100644 --- a/t/Timer.t +++ b/t/Timer.t @@ -102,6 +102,8 @@ ddg_goodie_test( '20 mins' => build_test('1200'), 'timer 20 minutes' => build_test('1200'), 'timer 60 minutes' => build_test('3600'), + 'start a timer for 20 minutes' => build_test('1200'), + 'set a timer to 60 minutes' => build_test('3600'), # Should not trigger 'start 30 minutes for timer' => undef, 'run with timer' => undef,