Zylann
/
godot_voxel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removed `get_size_x/y/z` convenience functions. 

They existed because Godot used to have only floating-point Vector3.
Now Godot has Vector3i so get_size() returns the right type.

Also, there was a bug in their implementation.
master
Marc Gilleron 2022-08-25 22:14:21 +01:00
parent 8ed72225a3
commit 4fb5e5cae3
2 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
storage/voxel_buffer_gd.cpp
View File

@ -277,9 +277,6 @@ void VoxelBuffer::_bind_methods() {
ClassDB::bind_method(D_METHOD("clear"), &VoxelBuffer::clear);
ClassDB::bind_method(D_METHOD("get_size"), &VoxelBuffer::get_size);
ClassDB::bind_method(D_METHOD("get_size_x"), &VoxelBuffer::get_size_x);
ClassDB::bind_method(D_METHOD("get_size_y"), &VoxelBuffer::get_size_y);
ClassDB::bind_method(D_METHOD("get_size_z"), &VoxelBuffer::get_size_z);
ClassDB::bind_method(D_METHOD("set_voxel", "value", "x", "y", "z", "channel"), &VoxelBuffer::set_voxel, DEFVAL(0));
ClassDB::bind_method(

10
storage/voxel_buffer_gd.h
View File

@ -89,16 +89,6 @@ public:
Vector3i get_size() const {
return _buffer->get_size();
}
// TODO Deprecate
int get_size_x() const {
return _buffer->get_size().x;
}
int get_size_y() const {
return _buffer->get_size().x;
}
int get_size_z() const {
return _buffer->get_size().x;
}
void create(int x, int y, int z) {
_buffer->create(x, y, z);