From 4fb5e5cae3537d9cb4654b66885a22ee0b1cf85a Mon Sep 17 00:00:00 2001 From: Marc Gilleron Date: Thu, 25 Aug 2022 22:14:21 +0100 Subject: [PATCH] Removed `get_size_x/y/z` convenience functions. They existed because Godot used to have only floating-point Vector3. Now Godot has Vector3i so get_size() returns the right type. Also, there was a bug in their implementation. --- storage/voxel_buffer_gd.cpp | 3 --- storage/voxel_buffer_gd.h | 10 ---------- 2 files changed, 13 deletions(-) diff --git a/storage/voxel_buffer_gd.cpp b/storage/voxel_buffer_gd.cpp index f32e6db4..12fda0d5 100644 --- a/storage/voxel_buffer_gd.cpp +++ b/storage/voxel_buffer_gd.cpp @@ -277,9 +277,6 @@ void VoxelBuffer::_bind_methods() { ClassDB::bind_method(D_METHOD("clear"), &VoxelBuffer::clear); ClassDB::bind_method(D_METHOD("get_size"), &VoxelBuffer::get_size); - ClassDB::bind_method(D_METHOD("get_size_x"), &VoxelBuffer::get_size_x); - ClassDB::bind_method(D_METHOD("get_size_y"), &VoxelBuffer::get_size_y); - ClassDB::bind_method(D_METHOD("get_size_z"), &VoxelBuffer::get_size_z); ClassDB::bind_method(D_METHOD("set_voxel", "value", "x", "y", "z", "channel"), &VoxelBuffer::set_voxel, DEFVAL(0)); ClassDB::bind_method( diff --git a/storage/voxel_buffer_gd.h b/storage/voxel_buffer_gd.h index 6f8cd56b..277f508f 100644 --- a/storage/voxel_buffer_gd.h +++ b/storage/voxel_buffer_gd.h @@ -89,16 +89,6 @@ public: Vector3i get_size() const { return _buffer->get_size(); } - // TODO Deprecate - int get_size_x() const { - return _buffer->get_size().x; - } - int get_size_y() const { - return _buffer->get_size().x; - } - int get_size_z() const { - return _buffer->get_size().x; - } void create(int x, int y, int z) { _buffer->create(x, y, z);