Remove some unused vars

mods/mobs/api.lua

@@ -320,7 +320,7 @@ function mobs:register_mob(name, def)
             local p = { x = pos.x / ps, z = pos.z / ps }
             local an = ( d.x * p.x ) + ( d.z * p.z )
 
-            a = math.deg( math.acos( an ) )
+            local a = math.deg( math.acos( an ) )
 
             if a > ( self.fov / 2 ) then
                return false

mods/rp_ambiance/init.lua

@@ -12,9 +12,6 @@ ambiance_local.sounds = {}
 -- immediately start singing when the rain ends.
 local WEATHER_CONDITION_DELAY = 5000000 -- µs
 
--- Minimum theoretical sunlight level required for birds to sing
-local BIRDS_MIN_LIGHT = 10
-
 -- Maximum cooldown time to prevent sound repetitions
 local SOUND_COOLDOWN_MAX = 3.0
 

mods/rp_default/achievements.lua

@@ -231,9 +231,6 @@ minetest.register_on_mods_loaded(function()
 		difficulty = 6.5,
 	})
 
-	local got_mineral = function(player, item)
-	end
-
 	for m=1, #minerals do
 		rp_checkitem.register_on_got_item(minerals[m], function(player)
 			achievements.trigger_subcondition(player, "find_all_minerals", minerals[m])

mods/rp_default/chest.lua

@@ -1,5 +1,4 @@
 local S = minetest.get_translator("rp_default")
-local F = minetest.formspec_escape
 
 local protection_check_move = function(pos, from_list, from_index, to_list, to_index, count, player)
     if minetest.is_protected(pos, player:get_player_name()) and

mods/rp_default/functions.lua

@@ -1,5 +1,4 @@
 local water_level = tonumber(minetest.get_mapgen_setting("water_level"))
-local S = minetest.get_translator("rp_default")
 
 -- If a sapling fails to grow, check the sapling again after this many seconds
 local SAPLING_RECHECK_TIME_MIN = 60

mods/rp_default/furnace.lua

@@ -3,7 +3,6 @@
 --
 
 local S = minetest.get_translator("rp_default")
-local F = minetest.formspec_escape
 
 function default.furnace_active_formspec(percent, item_percent)
    local form = rp_formspec.get_page("rp_formspec:2part")

mods/rp_gold/init.lua

@@ -46,7 +46,6 @@ gold.trades = {}
 gold.trade_names = {}
 
 local TRADE_FORMSPEC_OFFSET = 2.5
-local GOLD_COLOR = "#FFFF00FF"
 
 if minetest.get_modpath("mobs") ~= nil then
    gold.trades["farmer"] = {

mods/rp_hud/init.lua

@@ -200,7 +200,7 @@ minetest.register_globalstep(function(dtime)
       local player = players[p]
       local name = player:get_player_name()
       if not rp_hud.breath_timers[name] then
-         rp_breath_timers[name] = BREATH_KEEP_TIME + 1
+         rp_hud.breath_timers[name] = BREATH_KEEP_TIME + 1
       end
       if player:get_breath() >= minetest.PLAYER_MAX_BREATH_DEFAULT then
          rp_hud.breath_timers[name] = rp_hud.breath_timers[name] + dtime

mods/rp_util/init.lua

@@ -24,7 +24,7 @@ end
 -- TODO: Remove this function (it's deprecated)
 function util.fixlight(pos1, pos2)
    -- (function taken from WorldEdit)
-   local pos1, pos2 = util.sort_pos(pos1, pos2)
+   pos1, pos2 = util.sort_pos(pos1, pos2)
 
    --make area stay loaded
 

mods/rp_village/mapgen.lua

@@ -218,7 +218,6 @@ local function attempt_village_spawn(pos, village_type)
     end
 end
 
-local village_decoration_id
 if not minetest.settings:get_bool("mapgen_disable_villages") then
    -- Register dummy decorations to find possible village spawn points
    -- via gennotify.