Jordach
/
Minetest
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Optimize interaction distance checker (#8193) 

The "what" parameter is being passed by value, most likely by
accident as the type is "const std::string". Convert it to a
reference by adding the missing "&".
master
Jozef Behran 2019-03-07 02:19:13 -05:00 committed by Loïc Blot
parent 557afdc429
commit 007c8440d7
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/network/serverpackethandler.cpp
View File

@ -952,7 +952,7 @@ void Server::handleCommand_Respawn(NetworkPacket* pkt)
// the previous addition has been successfully removed // the previous addition has been successfully removed
} }
bool Server::checkInteractDistance(RemotePlayer *player, const f32 d, const std::string what) bool Server::checkInteractDistance(RemotePlayer *player, const f32 d, const std::string &what)
{ {
PlayerSAO *playersao = player->getPlayerSAO(); PlayerSAO *playersao = player->getPlayerSAO();
const InventoryList *hlist = playersao->getInventory()->getList("hand"); const InventoryList *hlist = playersao->getInventory()->getList("hand");

2
src/server.h
View File

@ -477,7 +477,7 @@ private:
void RespawnPlayer(session_t peer_id); void RespawnPlayer(session_t peer_id);
void DeleteClient(session_t peer_id, ClientDeletionReason reason); void DeleteClient(session_t peer_id, ClientDeletionReason reason);
void UpdateCrafting(RemotePlayer *player); void UpdateCrafting(RemotePlayer *player);
bool checkInteractDistance(RemotePlayer *player, const f32 d, const std::string what); bool checkInteractDistance(RemotePlayer *player, const f32 d, const std::string &what);
void handleChatInterfaceEvent(ChatEvent *evt); void handleChatInterfaceEvent(ChatEvent *evt);