Username wasn't sanitized before being used in the regex to check
the whitelist with, so a user named ... (literally three periods)
would be allowed to use the script as long as any user on the list
had a name three characters long. Thanks to MusikAnimal for pointing
this out.
i.e. no literal "~~~~", instead "~~"+"~~". Otherwise, there is the
potential for a bug if someone uploads the code by copying from the
source, and then their signature will get inserted
Because we used indexOf to check if a user is on the whitelist, users
whose usernames are substrings of usernames already on the list are
also allowed.
It's difficult to view the older, problematic revision when we've
cleared it. If we might put a CSD template on it anyway, and drafts are
already indexed, we don't need this option anymore.
If there's an OTRS notice on the draft's talk page when a reviewer goes to decline it as a copyright violation, pop up a notice warning the reviewer about the OTRS notice.
Per a discussion on the helper script talk page, the wording of the short descriptions of decline reasons (which are included in edit summaries when reviewers decline drafts) was somewhat bitey, so they've been changed from saying that topics *do not meet* notability guidlines to saying that they *have not yet been shown to meet* notability guidelines.
That's what I get for not testing adequately. Apparently, the `exists()` function of `Title` sometimes returns `true` when it isn't supposed to, leading to edits like [this one](https://en.wikipedia.org/w/index.php?diff=706488164).
I never knew that if the script encountered an existing Teahouse invitation on a user talk page, it wouldn't send another one. Only after looking through the source did I discover that there's no need to uncheck the box. Hence, this quick reminder that there's no need to check the user talk page.
Jest doesn’t work with Node 0.12.x (due to jsdom woes), but the 0.5.x
branch on GitHub has been updated and works with the latest version of
iojs. So, from now on, iojs must be used to build afch-rewrite (a la
nvm, probably). This should be added to the README/wiki…