Update Contribution Rules

master
rexim 2019-01-14 22:25:40 +07:00
parent d1063ab37a
commit b5cf976eb3
1 changed files with 2 additions and 2 deletions

View File

@ -29,14 +29,14 @@ Contributors are welcome to submit Issues and Pull Requests according to the rul
### Pull Requests
- Keep your PRs nice and small around 300 changes (including adding new lines). PRs that are way over that threshold won't be merged.
- Keep your PRs nice and small around 300 changes (including adding new lines). PRs that are way over that threshold won't be merged. Exceptions may apply if the reasons for a bigger PRs are communicated properly to the Project Leader in the description of the Pull Request.
- If 300 changes is not enough,
- make as many changes as you can according to the PR size limitation,
- make sure that the code is compilable and the application is usable,
- create TODOs right in the code for the unfinished work,
- submit PR with the unfinished work and TODOs,
- TODOs will be converted to separate issues
- Neglected PRs older than two weeks are gonna be automatically closed.
- Neglected PRs older than two weeks may be closed by Project Leader at any time.
- Don't get discouraged if your PR was not merged. The Rules and CI are designed to keep the quality of the code high so you don't have to worry about it yourself. Keep experimenting, keep improving.
[@rexim]: https://github.com/rexim