zaki
/
irrlicht
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adding a few const's and relaxing the Irrlicht.ruleset. 

No more checking for all the VS specific annotation stuff in code analysis (we don't use this anyway).
Also less const checks (arguably make code nicer, but not really helping finding suspcious code places, just lots of noise).

git-svn-id: svn://svn.code.sf.net/p/irrlicht/code/trunk@5857 dfc29bdd-3216-0410-991c-e03cc46cb475
master
cutealien 2019-08-21 17:37:28 +00:00
parent eb02bd0c56
commit 004d250e8f
4 changed files with 76 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/ICameraSceneNode.h
View File

@ -193,7 +193,7 @@ namespace scene
protected:
void cloneMembers(ICameraSceneNode* toCopyFrom)
void cloneMembers(const ICameraSceneNode* toCopyFrom)
{
IsOrthogonal = toCopyFrom->IsOrthogonal;
}

2
include/IQ3Shader.h
View File

@ -762,7 +762,7 @@ namespace quake3
*/
inline void getTextures(tTexArray &textures,
const core::stringc &name, u32 &startPos,
io::IFileSystem *fileSystem,
const io::IFileSystem *fileSystem,
video::IVideoDriver* driver)
{
static const char * const extension[] =

2
source/Irrlicht/CXMLReaderImpl.h
View File

@ -508,7 +508,7 @@ private:
// replaces xml special characters in a string and creates a new one
core::string<char_type> replaceSpecialCharacters(
core::string<char_type>& origstr)
const core::string<char_type>& origstr)
{
int pos = origstr.findFirst(L'&');
int oldPos = 0;

73
source/Irrlicht/Irrlicht.ruleset
View File

@ -249,12 +249,16 @@
<Rule Id="C26438" Action="None" />
<Rule Id="C26440" Action="None" />
<Rule Id="C26443" Action="None" />
<Rule Id="C26444" Action="None" />
<Rule Id="C26445" Action="None" />
<Rule Id="C26446" Action="None" />
<Rule Id="C26447" Action="None" />
<Rule Id="C26448" Action="None" />
<Rule Id="C26449" Action="None" />
<Rule Id="C26451" Action="None" />
<Rule Id="C26455" Action="None" />
<Rule Id="C26459" Action="None" />
<Rule Id="C26461" Action="None" />
<Rule Id="C26466" Action="None" />
<Rule Id="C26472" Action="None" />
<Rule Id="C26477" Action="None" />
@ -269,7 +273,76 @@
<Rule Id="C26495" Action="None" />
<Rule Id="C26496" Action="Warning" />
<Rule Id="C26497" Action="None" />
<Rule Id="C28204" Action="None" />
<Rule Id="C28205" Action="None" />
<Rule Id="C28209" Action="None" />
<Rule Id="C28210" Action="None" />
<Rule Id="C28211" Action="None" />
<Rule Id="C28212" Action="None" />
<Rule Id="C28213" Action="None" />
<Rule Id="C28214" Action="None" />
<Rule Id="C28215" Action="None" />
<Rule Id="C28216" Action="None" />
<Rule Id="C28217" Action="None" />
<Rule Id="C28218" Action="None" />
<Rule Id="C28219" Action="None" />
<Rule Id="C28220" Action="None" />
<Rule Id="C28221" Action="None" />
<Rule Id="C28222" Action="None" />
<Rule Id="C28223" Action="None" />
<Rule Id="C28224" Action="None" />
<Rule Id="C28225" Action="None" />
<Rule Id="C28226" Action="None" />
<Rule Id="C28227" Action="None" />
<Rule Id="C28228" Action="None" />
<Rule Id="C28229" Action="None" />
<Rule Id="C28230" Action="None" />
<Rule Id="C28231" Action="None" />
<Rule Id="C28232" Action="None" />
<Rule Id="C28233" Action="None" />
<Rule Id="C28234" Action="None" />
<Rule Id="C28235" Action="None" />
<Rule Id="C28236" Action="None" />
<Rule Id="C28237" Action="None" />
<Rule Id="C28238" Action="None" />
<Rule Id="C28239" Action="None" />
<Rule Id="C28240" Action="None" />
<Rule Id="C28241" Action="None" />
<Rule Id="C28243" Action="None" />
<Rule Id="C28244" Action="None" />
<Rule Id="C28245" Action="None" />
<Rule Id="C28246" Action="None" />
<Rule Id="C28250" Action="None" />
<Rule Id="C28251" Action="None" />
<Rule Id="C28252" Action="None" />
<Rule Id="C28253" Action="None" />
<Rule Id="C28254" Action="None" />
<Rule Id="C28260" Action="None" />
<Rule Id="C28262" Action="None" />
<Rule Id="C28263" Action="None" />
<Rule Id="C28266" Action="None" />
<Rule Id="C28267" Action="None" />
<Rule Id="C28272" Action="None" />
<Rule Id="C28273" Action="None" />
<Rule Id="C28285" Action="None" />
<Rule Id="C28286" Action="None" />
<Rule Id="C28287" Action="None" />
<Rule Id="C28288" Action="None" />
<Rule Id="C28289" Action="None" />
<Rule Id="C28290" Action="None" />
<Rule Id="C28291" Action="None" />
<Rule Id="C28300" Action="None" />
<Rule Id="C28301" Action="None" />
<Rule Id="C28302" Action="None" />
<Rule Id="C28303" Action="None" />
<Rule Id="C28304" Action="None" />
<Rule Id="C28305" Action="None" />
<Rule Id="C28306" Action="None" />
<Rule Id="C28307" Action="None" />
<Rule Id="C28308" Action="None" />
<Rule Id="C28309" Action="None" />
<Rule Id="C28350" Action="None" />
<Rule Id="C28351" Action="None" />
<Rule Id="C6326" Action="None" />
</Rules>
</RuleSet>