remove pointless default dep, add luacheck, add github actions

.github/workflows/luacheck.yml

@@ -0,0 +1,17 @@
+name: luacheck
+
+on: [push, pull_request]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: apt
+      run: sudo apt-get install -y luarocks
+    - name: luacheck install
+      run: luarocks install --local luacheck
+    - name: luacheck run
+      run: $HOME/.luarocks/bin/luacheck ./

.luacheckrc

@@ -0,0 +1,22 @@
+unused_args = false
+allow_defined_top = true
+
+exclude_files = {".luacheckrc"}
+
+globals = {
+    "minetest", "core",
+}
+
+read_globals = {
+    string = {fields = {"split"}},
+    table = {fields = {"copy", "getn"}},
+
+    --luac
+    "math", "table",
+
+    -- Builtin
+    "vector", "ItemStack", "dump", "DIR_DELIM", "VoxelArea", "Settings", "PcgRandom", "VoxelManip", "PseudoRandom",
+
+    --mod provided
+    "unified_inventory",
+}

depends.txt

@@ -1,2 +0,0 @@
-default
-unified_inventory?

mod.conf

@@ -1,7 +1,6 @@
 author = xenonca
 description = Allows players to have perma time without changing the game time.
-version = 1.2
+version = 1.3
 title = Perma Time
 name = ptime
-depends = default
 optional_depends = unified_inventory

ptime_ui/depends.txt

@@ -1 +0,0 @@
-unified_inventory

ptime_ui/init.lua

@@ -1,83 +0,0 @@
-if minetest.global_exists("unified_inventory") then
-	minetest.log("action", "ui exists")
-
-minetest.register_privilege("daylight", {
-    description = "Can set Perma Time"
-})
-
-unified_inventory.register_button("ptime", {
-	type = "image",
-	image = "ptime.png",
-	tooltip = ("Perma Time"),
-	hide_lite=true,
-	action = function(player)
-		local player_name = player:get_player_name()
-		if minetest.check_player_privs(player_name, {daylight=true}) then
-			if player:get_attribute("ptime") == nil
-			   or player:get_attribute("ptime") == "" then
-				player:set_attribute("ptime", "day")
-				player:override_day_night_ratio(1)
-				minetest.chat_send_player(player_name,
-					("-!- Perma Day enabled"))
-
-			elseif	player:get_attribute("ptime") == "day" then
-					player:set_attribute("ptime", "night")
-					player:override_day_night_ratio(.1)
-					minetest.chat_send_player(player_name,
-						("-!- Perma Night enabled"))
-
-			elseif player:get_attribute("ptime") == "night" then
-					player:set_attribute("ptime", "")
-					player:override_day_night_ratio(nil)
-					minetest.chat_send_player(player_name,
-						("-!- Perma Time disabled"))
-			end
-		else
-		minetest.chat_send_player(player_name,
-			("You don't have the \"daylight\" privilege!"))
-		end
-end,
-})
-end
-
-local function ptime(name)
-	local player = minetest.get_player_by_name(name)
-	if player:get_attribute("ptime") == nil
-	or player:get_attribute("ptime") == "" then
-		player:set_attribute("ptime", "day")
-		player:override_day_night_ratio(1)
-		minetest.chat_send_player(name, "-!- Perma Day has been enabled") elseif
-		player:get_attribute("ptime") == "day" then
-		player:set_attribute("ptime", "night")
-		player:override_day_night_ratio(.1)
-		minetest.chat_send_player(name, "-!- Perma Night has been enabled") elseif
-		player:get_attribute("ptime") == "night" then
-		player:set_attribute("ptime", nil)
-		player:override_day_night_ratio(nil)
-		minetest.chat_send_player(name, "-!- Perma Time has been disabled")
-  end
-end
-
-minetest.register_chatcommand("ptime", {
-  privs = {
-        daylight = true,
-    },
-  description = ("Set a permanent day time"),
-  func = function(name)
-    local player = minetest.get_player_by_name(name)
-      if player == nil then
-        return false, "Player does not exist!"
-      end
-  ptime(name)
-end
-})
-
-minetest.register_on_joinplayer(function(player)
-	local player_name = player:get_player_name()
-	if player:get_attribute("ptime") == "day"
-	then player:override_day_night_ratio(1)
-	minetest.chat_send_player(player_name, "-!- Perma Day is enabled")
-	elseif player:get_attribute("ptime") == "night" then
-	player:override_day_night_ratio(".1")
-	minetest.chat_send_player(player_name, "-!- Perma Night is enabled") end
-end)