tmenier/Flurl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #657 from wrexbe/656-fix-queryparams-contains

Browse Source 
#656 QueryParams contains bug
This commit is contained in:
Todd Menier 2021-10-11 09:02:14 -05:00 committed by GitHub
commit 27d350ecdf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Test/Flurl.Test/UrlBuilder/UrlParsingTests.cs
View File

@ -115,5 +115,13 @@ namespace Flurl.Test.UrlBuilder
var url = new Url(expected); var url = new Url(expected);
Assert.AreEqual(expected, url.ToString()); Assert.AreEqual(expected, url.ToString());
} }
[Test] // #656
public void queryparams_uses_equals() {
var url = new Url("http://www.mysite.com?param=1");
// String gets boxed, so we need to use Equals, instead of ==
var contains = url.QueryParams.Contains("param", "1");
Assert.IsTrue(contains);
}
} }
} }

2
src/Flurl/QueryParamCollection.cs
View File

@ -161,7 +161,7 @@ namespace Flurl
public bool Contains(string name) => _values.Contains(name); public bool Contains(string name) => _values.Contains(name);
/// <inheritdoc />> /// <inheritdoc />>
public bool Contains(string name, object value) => _values.Any(qv => qv.Name == name && qv.Value.Value == value); public bool Contains(string name, object value) => _values.Any(qv => qv.Name == name && qv.Value.Value.Equals(value));
} }
/// <summary> /// <summary>