Setting hp_max before player actually emerges in a
join event seems to prevent damage flash (MT engine
issue 7876) for new players.
Old players rejoining for the first time since the
change will still experience it though.
It seems that when we access metadata too rapidly
it pulls data out of order or something, so that the
player damage time stuff is unstable, and healing can
start immediately, or more than 8 seconds later.
Caching this stuff manually seems to work around the
issue, and it seems that the metadata system is at
least EVENTUALLY consistent, so it's still good for
long-term use or across world unloads.
- Player hp_max is 8 now, so most injuries will block
a whole slot each time.
- Player can be reduced to 1 slot, not 2. The 2 slots
was from back in the day when players needed to go
to the surface to heal faster, to help them get up
there. Now the 1 slot is only needed in case the
player is trapped in fire or something.
- Damage effects now don't stop playing just because
the player has reached maximum injury, and healing
is also delayed by continued injury.
If players are invisible, NodeCore will not add any visible or
audible effects for them, allowing such players to be completely
non-interactive with gameplay.
This allows things like spectator or stealth-admin mods to
function properly.
- Healing rate is always the same, regardless of environment.
- Remove visible damage from player.
Lasting injury has just never really been a major gameplay
factor, and making players wait to heal under certain
circumstances did not feel like it made gameplay "better" in
any way.
Now, if you get hurt, you drop your stuff, and have to wait a
MINIMAL amount of time before you can pick it up again.
Similarly, with visible inventory, the damage textures are
redundant, and with the gameplay importance of injury being
so diminished, they were visual overkill.
Try to detect player traces going through a change in fluid medium
such as water/air or water/glass, and block facial recognition
through it.
Specifically allow air-into-glass transitions, or into any other
medium otherwise clear enough to allow sunlight to propagate.
Standardize the "play a sound for everybody except the player who
is already playing it client-locally" logic into one place.
Fix failure to correctly detect tool speeds for some things, i.e.
when the player is using a tool but the capability used on a node
is actually inherited from the hand.
Note that this may allow pummeling with wrong tools (e.g. repacking
soils with spades) along with accompanying inappropriate tool wear,
but this should be minor and avoidable, and can be fixed later...
