Sync up rotation application with old spin API

- Call a callback if present after rotation
- Action logging
- Use swap_node so metadata isn't lost

docs/issues-game.txt

@@ -9,6 +9,25 @@ ISSUES-GAME: Gameplay-affecting issues
  #    #  #       #    #     #    #       #       #   #   #    #
   ####   #        ####      #    ######  ######  #    #   ####
 
+- Most HUDs lack z-index
+	- Looktips obscured by new rotation HUDs probably shouldn't be
+
+- Make tongs extensible
+	- Instead of checking for known glowing lode, use groups
+	- A group for tong-able
+	- A group to control wear rate
+	- Move existing load stuff into groups
+
+- New Rotation System Issues
+	- Enroll writing system
+	- Fallback behavior when a direction is unavailable makes no
+	  sense.
+		- Can cause a hotspot to change meaning as rotating
+		- Intended for writing rotations
+		- Should we go back to defining only 3D or 2D and not
+		  trying to support both with 1 method?
+			- May make sense with dots anyway
+
 - Totes should honor on_rightclick handlers in on_place.
 
 - Need to try to address issues with items settling in pum pools.

mods/nc_api_rotate/api.lua

@@ -78,7 +78,7 @@ local function getcheck(pname, pos, group)
 	if not (grps and (grps[group] or 0) > 0) then return end
 	local rots = def.nc_rotations
 	if not rots then return end
-	return pos, node, rots
+	return pos, node, rots, def
 end
 
 function nodecore.rotation_compute(player, pointed_thing)
@@ -88,9 +88,9 @@ function nodecore.rotation_compute(player, pointed_thing)
 
 	if not nodecore.interact(player) then return end
 	local pname = player:get_player_name()
-	local pos, node, lut = getcheck(pname, pointed_thing.above, "nc_api_rotate_above")
+	local pos, node, lut, def = getcheck(pname, pointed_thing.above, "nc_api_rotate_above")
 	if not pos then
-		pos, node, lut = getcheck(pname, pointed_thing.under, "nc_api_rotate_under")
+		pos, node, lut, def = getcheck(pname, pointed_thing.under, "nc_api_rotate_under")
 		if not pos then return end
 	end
 
@@ -108,7 +108,7 @@ function nodecore.rotation_compute(player, pointed_thing)
 	and facerel.x > -rotation_center_ratio and facerel.x < rotation_center_ratio
 	and facerel.y > -rotation_center_ratio and facerel.y < rotation_center_ratio
 	and facerel.z > -rotation_center_ratio and facerel.z < rotation_center_ratio
-	then return pos, node, cdata end
+	then return pos, node, cdata, def end
 
 	local rotdir = vec_to_dir(facerel)
 	local rdata = {
@@ -118,9 +118,9 @@ function nodecore.rotation_compute(player, pointed_thing)
 		rotdir = rotdir,
 	}
 	rdata.param2 = lut[rotkey(rdata.vector, node.param2)]
-	if rdata.param2 then return pos, node, rdata end
+	if rdata.param2 then return pos, node, rdata, def end
 
-	if cdata.param2 then return pos, node, cdata end
+	if cdata.param2 then return pos, node, cdata, def end
 end
 
 local function raycast(player)
@@ -148,11 +148,18 @@ function nodecore.rotation_apply(player, pointed_thing)
 		and pt.under and vector_equals(pt.under, pointed_thing.under))
 	then return end
 
-	local pos, node, rotdata = nodecore.rotation_compute(player, pt)
+	local pos, node, rotdata, def = nodecore.rotation_compute(player, pt)
 	if not rotdata then return end
 
+	if player:is_player() then
+		nodecore.log("action", player:get_player_name() .. " rotates "
+			.. node.name .. " at " .. minetest.pos_to_string(pos)
+			.. " from param2 " .. node.param2 .. " to " .. rotdata.param2)
+	end
 	node.param2 = rotdata.param2
-	nodecore.set_loud(pos, node)
+	minetest.swap_node(pos, node)
+	nodecore.node_sound(pos, "place")
+	if def.on_nc_rotate then def.on_nc_rotate(pos, node) end
 end
 
 function nodecore.rotation_on_rightclick(_, _, clicker, _, pointed)

mods/nc_optics/lens.lua

@@ -66,7 +66,7 @@ local basedef = {
 	drop = modname .. ":lens",
 	on_construct = nodecore.optic_check,
 	on_destruct = nodecore.optic_check,
-	on_spin = nodecore.optic_immediate,
+	on_nc_rotate = nodecore.optic_immediate,
 	after_place_node = nodecore.optic_immediate,
 	optic_check = lens_check,
 	paramtype = "light",

mods/nc_optics/prism.lua

@@ -57,7 +57,7 @@ local basedef = {
 	drop = modname .. ":prism",
 	on_construct = nodecore.optic_check,
 	on_destruct = nodecore.optic_check,
-	on_spin = nodecore.optic_immediate,
+	on_nc_rotate = nodecore.optic_immediate,
 	after_place_node = nodecore.optic_immediate,
 	optic_check = prism_check,
 	paramtype = "light",