sztest/nodecore-cd2025
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix tote AISM over-modification

Browse Source 
Carrying a tote with an infused tool inside would
cause the tote to repeatedly animate item
switching because the infused tool's soaking AISM
would keep returning a new item stack, causing
the tote to detect a "dirty" state, reserialize its
data, and thus keep changing metadata.

Detect if we're setting an item string to the same
string it already was, and don't mark it as dirty
if so, fixing this.
This commit is contained in:
Aaron Suen 2021-08-09 07:26:26 -04:00
parent 4ed265558f
commit 1b0a506633
1 changed files with 26 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
mods/nc_tote/aism.lua
View File

@ -17,17 +17,22 @@ nodecore.register_aism({
local dirty
for _, slot in pairs(inv) do
-- Modern format
if slot and slot.m and slot.m.fields and slot.m.fields.ncitem then
local istack = ItemStack(slot.m.fields.ncitem)
local sdata = {
pos = data.pos,
toteslot = slot,
set = function(s)
slot.m.fields.ncitem = s:to_string()
dirty = true
end
}
local ncitem = slot and slot.m and slot.m.fields
and slot.m.fields.ncitem
if ncitem then
local istack = ItemStack(ncitem)
if not istack:is_empty() then
local sdata = {
pos = data.pos,
toteslot = slot,
set = function(s)
local ss = s:to_string()
if ss ~= ncitem then
slot.m.fields.ncitem = ss
dirty = true
end
end
}
nodecore.aism_check_stack(istack, sdata)
end
end
@ -35,18 +40,18 @@ nodecore.register_aism({
for lname, list in pairs(slot and slot.m and slot.m.inventory or {}) do
for sub, item in pairs(list) do
local istack = ItemStack(item)
local sdata = {
pos = data.pos,
toteslot = slot,
totelistname = lname,
totelist = list,
totesubslot = sub,
set = function(s)
list[sub] = s:to_string()
dirty = true
end
}
if not istack:is_empty() then
local sdata = {
pos = data.pos,
toteslot = slot,
totelistname = lname,
totelist = list,
totesubslot = sub,
set = function(s)
list[sub] = s:to_string()
dirty = true
end
}
nodecore.aism_check_stack(istack, sdata)
end
end