Rename Glass Tank to Glass Case

This caused copious confusion for new players, who assume the
glass "tank" is like an aquarium tank and can be used to carry
water.  Originally it was intended to seal in "moisture" for
sponge transport, but that has become a far less important use
case (and in fact sponge transport is probably best done just by
building submerged pathways, like the way amalgam transport is
done) and glass "tanks" are more like "display cases" now, or an
intermediate storage container that adds top access (useful for
totes).

docs/issues-game.txt

@@ -18,8 +18,8 @@ ISSUES-GAME: Gameplay-affecting issues
 		- Exempt thrown items from hurting players for a
 		  second or so after being thrown
 - Fix crappy sponge death mechanic
-	- Remove special treatment of glass tank and glass nodes
-		- May need to find a new use-case for glass tank?
+	- Remove special treatment of glass case and glass nodes
+		- May need to find a new use-case for glass case?
 	- Use majority heuristic for sponge death in node form
 		- Death if dry nodes > 0 and >= wet nodes nearby
 		- Ignore sealing nodes
@@ -174,7 +174,7 @@ ISSUES-GAME: Gameplay-affecting issues
 	- Shelf frame can gain its own distinct uses
 		- e.g. some things can fall through it but not others.
 		  Items?  Players?  Fluids?
-	- For glass tank, dig out center of clear glass w/ pick?
+	- For glass case, dig out center of clear glass w/ pick?
 
 - Should there be pockets of softer stone at depth, like there is gravel?
 	- Register ores for softer stone of each level

mods/nc_optics/crafting.lua

@@ -46,7 +46,7 @@ nodecore.register_craft({
 	})
 
 nodecore.register_craft({
-		label = "hammer tank to crude",
+		label = "hammer case to crude",
 		action = "pummel",
 		priority = -1,
 		toolgroups = {thumpy = 3},

mods/nc_optics/hints.lua

@@ -58,11 +58,11 @@ nodecore.register_hint("gate a prism",
 	"nc_optics:lens_on"
 )
 
-nodecore.register_hint("assemble a clear glass tank",
-	"assemble clear glass tank",
+nodecore.register_hint("assemble a clear glass case",
+	"assemble clear glass case",
 	{"nc_optics:glass", "nc_woodwork:frame"}
 )
-nodecore.register_hint("assemble a float glass tank",
-	"assemble float glass tank",
+nodecore.register_hint("assemble a float glass case",
+	"assemble float glass case",
 	{"nc_optics:glass_float", "nc_woodwork:frame"}
 )

mods/nc_optics/shelf.lua

@@ -13,7 +13,7 @@ local txr_frame = modname .. "_glass_edges.png^(nc_tree_tree_side.png^[mask:"
 local function register_tank(subname, desc, pane, recipeitem)
 	local tankname = modname .. ":" .. subname
 	minetest.register_node(tankname, {
-			description = desc .. " Glass Tank",
+			description = desc .. " Glass Case",
 			tiles = {
 				pane .. txr_frame,
 				pane .. txr_frame,
@@ -45,7 +45,7 @@ local function register_tank(subname, desc, pane, recipeitem)
 			end
 		})
 
-	local craftlabel = "assemble " .. string_lower(desc) .. " glass tank"
+	local craftlabel = "assemble " .. string_lower(desc) .. " glass case"
 	nodecore.register_craft({
 			label = craftlabel,
 			norotate = true,