sztest/nodecore-cd2025
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
nodecore-cd2025/mods/nc_api_active/abminvert.lua

40 lines
927 B
Lua
Raw Normal View History

ABM "inversion" API This is useful when we want to perform an action on a commonly-occuring node (like sand or item stacks) with a requirement of a neighbor of a less common node type (like igniters). Checking for B with A nearby can be a lot faster than A with B nearby if B is less common, so fewer neighbor checks actually need to happen. This was already done "manually" for the flammable/igniter interaction, but now this is a general API for all ABMs, that allows the inversion to be done nearly transparently with just a flag in the definition, and so the ABM rules can be written more simply, with the inversion handled elsewhere. TODO: Rewrite current manual-inversions, including the ones for flammable/igniter and lava/stone hardening/softening.
2021-03-21 12:08:08 -04:00
-- LUALOCALS < ---------------------------------------------------------
Un-delay inverted ABMs Instead of queueing inverted ABMs and then running them out-of-band, run them inside the normal ABM schedule time. This should: - Prevent ABM mux lookup problems caused by nodes changing after a delayed inverted ABM schedule and the action actually running - Allow the ABM scheduler to better account for the time spent running inverted ABM actions, to ensure that they properly count against the default 0.2s ABM runtime budget and can't spike lag up higher.
2021-12-05 14:11:01 -05:00
local ipairs, minetest, nodecore
= ipairs, minetest, nodecore
ABM "inversion" API This is useful when we want to perform an action on a commonly-occuring node (like sand or item stacks) with a requirement of a neighbor of a less common node type (like igniters). Checking for B with A nearby can be a lot faster than A with B nearby if B is less common, so fewer neighbor checks actually need to happen. This was already done "manually" for the flammable/igniter interaction, but now this is a general API for all ABMs, that allows the inversion to be done nearly transparently with just a flag in the definition, and so the ABM rules can be written more simply, with the inversion handled elsewhere. TODO: Rewrite current manual-inversions, including the ones for flammable/igniter and lava/stone hardening/softening.
2021-03-21 12:08:08 -04:00
-- LUALOCALS > ---------------------------------------------------------
local hash = minetest.hash_node_position
local oldreg = minetest.register_abm
function minetest.register_abm(def, ...)
if not def.neighbors_invert then return oldreg(def, ...) end
local nnames = def.nodenames
def.nodenames = def.neighbors
def.neighbors = nnames
local oldact = def.action
Un-delay inverted ABMs Instead of queueing inverted ABMs and then running them out-of-band, run them inside the normal ABM schedule time. This should: - Prevent ABM mux lookup problems caused by nodes changing after a delayed inverted ABM schedule and the action actually running - Allow the ABM scheduler to better account for the time spent running inverted ABM actions, to ensure that they properly count against the default 0.2s ABM runtime budget and can't spike lag up higher.
2021-12-05 14:11:01 -05:00
local dirty
local blocked = {}
ABM "inversion" API This is useful when we want to perform an action on a commonly-occuring node (like sand or item stacks) with a requirement of a neighbor of a less common node type (like igniters). Checking for B with A nearby can be a lot faster than A with B nearby if B is less common, so fewer neighbor checks actually need to happen. This was already done "manually" for the flammable/igniter interaction, but now this is a general API for all ABMs, that allows the inversion to be done nearly transparently with just a flag in the definition, and so the ABM rules can be written more simply, with the inversion handled elsewhere. TODO: Rewrite current manual-inversions, including the ones for flammable/igniter and lava/stone hardening/softening.
2021-03-21 12:08:08 -04:00
function def.action(pos)
Un-delay inverted ABMs Instead of queueing inverted ABMs and then running them out-of-band, run them inside the normal ABM schedule time. This should: - Prevent ABM mux lookup problems caused by nodes changing after a delayed inverted ABM schedule and the action actually running - Allow the ABM scheduler to better account for the time spent running inverted ABM actions, to ensure that they properly count against the default 0.2s ABM runtime budget and can't spike lag up higher.
2021-12-05 14:11:01 -05:00
if not dirty then
dirty = true
minetest.after(0, function()
blocked = {}
dirty = nil
end)
ABM "inversion" API This is useful when we want to perform an action on a commonly-occuring node (like sand or item stacks) with a requirement of a neighbor of a less common node type (like igniters). Checking for B with A nearby can be a lot faster than A with B nearby if B is less common, so fewer neighbor checks actually need to happen. This was already done "manually" for the flammable/igniter interaction, but now this is a general API for all ABMs, that allows the inversion to be done nearly transparently with just a flag in the definition, and so the ABM rules can be written more simply, with the inversion handled elsewhere. TODO: Rewrite current manual-inversions, including the ones for flammable/igniter and lava/stone hardening/softening.
2021-03-21 12:08:08 -04:00
end
for _, npos in ipairs(nodecore.find_nodes_around(pos, nnames, 1)) do
Un-delay inverted ABMs Instead of queueing inverted ABMs and then running them out-of-band, run them inside the normal ABM schedule time. This should: - Prevent ABM mux lookup problems caused by nodes changing after a delayed inverted ABM schedule and the action actually running - Allow the ABM scheduler to better account for the time spent running inverted ABM actions, to ensure that they properly count against the default 0.2s ABM runtime budget and can't spike lag up higher.
2021-12-05 14:11:01 -05:00
local key = hash(npos)
if not blocked[key] then
blocked[key] = true
oldact(npos, minetest.get_node(npos))
end
ABM "inversion" API This is useful when we want to perform an action on a commonly-occuring node (like sand or item stacks) with a requirement of a neighbor of a less common node type (like igniters). Checking for B with A nearby can be a lot faster than A with B nearby if B is less common, so fewer neighbor checks actually need to happen. This was already done "manually" for the flammable/igniter interaction, but now this is a general API for all ABMs, that allows the inversion to be done nearly transparently with just a flag in the definition, and so the ABM rules can be written more simply, with the inversion handled elsewhere. TODO: Rewrite current manual-inversions, including the ones for flammable/igniter and lava/stone hardening/softening.
2021-03-21 12:08:08 -04:00
end
end
return oldreg(def, ...)
end
Reference in New Issue Copy Permalink