Missing or wrong node sounds

A couple of nodes have missing or wrong node sounds:

    nodes:hardened_clay*: Plays no sound (suggested sound: stone sound)
    nodes:chest_with_*: No sound (suggested: wood sound)
    nodes:flowerpot*: Plays wood sound (suggested: stone sound)
    nodes:vine*: Wood sound when climbing (suggested: leaves sound)
    terminal:terminal: No sound (suggested: metal sound)
    nodes:tnt: No sound (suggested: wood sound)
    signs:bg: No sound (suggested: stone sound)
    All doors and fence gates: No sounds for placing/digging
    frame:*: No sound (suggested: wood sound)
    signs:sign_wall: No sound (suggested: wood sound)

Special cases:

    Trampoline: Wood sound
    Waterlily: No change, still no sound (leaves sound would be too odd here)
    Lava: Sound removed
    boxes:nexus: No change, I have no good idea
    Sponge: Dirt sound
    Rope: Sound removed (other sounds just don't fit well)
This commit is contained in:
Wuzzy 2019-04-15 21:08:52 -07:00 committed by Auke Kok
parent ce88c6a67f
commit aa7ab7b0ff
8 changed files with 37 additions and 13 deletions

View File

@ -1,2 +1,3 @@
mech
sounds
screwdriver?

View File

@ -306,6 +306,10 @@ function doors.register(name, def)
local meta = minetest.get_meta(pos)
meta:set_int("state", state)
if def.sounds and def.sounds.place then
minetest.sound_play(def.sounds.place,
{pos = pos, gain = 1.0, max_hear_distance = 32})
end
on_place_node(pos, minetest.get_node(pos),
placer, node, itemstack, pointed_thing)
@ -393,6 +397,7 @@ doors.register("door_wood", {
description = "Wooden door",
inventory_image = "itb_doors_item_wood.png",
groups = {unbreakable = 1, node = 1, door = 1},
sounds = sounds.wood,
})
doors.register("door_steel", {
@ -401,6 +406,7 @@ doors.register("door_steel", {
inventory_image = "itb_doors_item_steel.png",
protected = true,
groups = {unbreakable = 2, node = 2, door = 1},
sounds = sounds.metal,
sound_open = "doors_steel_door_open",
sound_close = "doors_steel_door_close",
})
@ -518,6 +524,7 @@ doors.register_trapdoor("doors:trapdoor", {
tile_front = "itb_doors_trapdoor.png",
tile_side = "itb_doors_trapdoor_side.png",
groups = {unbreakable = 1, node = 1, door = 1},
sounds = sounds.wood,
})
doors.register_trapdoor("doors:trapdoor_steel", {
@ -530,6 +537,7 @@ doors.register_trapdoor("doors:trapdoor_steel", {
sound_open = "doors_steel_door_open",
sound_close = "doors_steel_door_close",
groups = {unbreakable = 2, node = 2, door = 1},
sounds = sounds.metal,
})
@ -568,6 +576,7 @@ function doors.register_fencegate(name, def)
},
on_trigger = on_trigger,
on_untrigger = on_trigger,
sounds = def.sounds,
}
fence.groups.fence = 1
@ -599,18 +608,21 @@ end
doors.register_fencegate("doors:gate_wood_medium", {
description = "Medium wood fence gate",
texture = "blocks_tiles.png^[sheet:8x8:2,3",
groups = {node = 1}
groups = {node = 1},
sounds = sounds.wood,
})
doors.register_fencegate("doors:gate_wood_dark", {
description = "Dark wood fence gate",
texture = "blocks_tiles.png^[sheet:8x8:0,3",
groups = {node = 1},
sounds = sounds.wood,
})
doors.register_fencegate("doors:gate_wood_light", {
description = "Light wood fence gate",
texture = "blocks_tiles.png^[sheet:8x8:1,3",
groups = {node = 1}
groups = {node = 1},
sounds = sounds.wood,
})

View File

@ -216,6 +216,7 @@ function frame.register(name)
"#88ff44", "> locked = " .. locked
))
end,
sounds = sounds.wood,
})
end
@ -244,6 +245,7 @@ minetest.register_node("frame:empty", {
},
groups = {oddly_breakable_by_hand = 3, cracky = 1},
on_rightclick = frame_on_rightclick,
sounds = sounds.wood,
})
-- inception!

View File

@ -455,14 +455,14 @@ for n, v in pairs({"black", "violet", "brown", "cyan",
description = nm(v .. " hardened clay"),
tiles = {tex},
groups = {node = 1, unbreakable = 1},
sounds = sounds.clay,
sounds = sounds.stone,
})
make_stair_slab("hardened_clay_" .. v, nm(v .. " hardened clay"), {node = 1, unbreakable = 1}, "", "", sounds.cloth, tex)
minetest.register_node("nodes:hardened_clay_" .. v .. "_breakable", {
description = nm(v .. " hardened clay"),
tiles = {tex},
groups = {pickaxe = 1, node = 1},
sounds = sounds.cloth,
sounds = sounds.stone,
})
make_stair_slab("hardened_clay_" .. v, nm(v .. " hardened clay"), {axe = 1, node = 1}, "_breakable", "", sounds.cloth, tex)
frame.register("nodes:hardened_clay_" .. v .. "_breakable")
@ -825,9 +825,9 @@ frame.register("nodes:hay_breakable")
-- ladders, rope & vines
for _, n in pairs({
{"ladder", "signlike"},
{"rope", "plantlike"},
{"vine", "signlike"},
{"ladder", "signlike", sounds.wood},
{"rope", "plantlike", nil},
{"vine", "signlike", sounds.leaves},
}) do
local tex
if n[1] == "vine" then
@ -851,7 +851,7 @@ for _, n in pairs({
fixed = {-3/16, -1/2, -3/16, 3/16, 1/2, 3/16}
},
groups = {node = 1, unbreakable = 1},
sounds = sounds.wood,
sounds = n[3],
})
minetest.register_node("nodes:" .. n[1] .. "_breakable", {
description = nm(n[1]),
@ -869,7 +869,7 @@ for _, n in pairs({
fixed = {-3/16, -1/2, -3/16, 3/16, 1/2, 3/16}
},
groups = {node = 1, axe = 1},
sounds = sounds.wood,
sounds = n[3],
})
frame.register("nodes:" .. n[1] .. "_breakable")
end
@ -917,6 +917,7 @@ for _, v in pairs({20, 40, 60, 80}) do
paramtype = "light",
paramtype2 = "facedir",
groups = {node = 1, bouncy = v, fall_damage_add_percent = -v},
sounds = sounds.wood,
})
end
@ -926,6 +927,7 @@ minetest.register_node("nodes:sponge", {
tiles = {"sponge.png"},
paramtype = "light",
groups = {node = 1, fall_damage_add_percent = -25, disable_jump = 1},
sounds = sounds.dirt,
-- fall ~25 nodes, normal node = 1 heart left, sponge = 5 hearts left
})
@ -964,6 +966,7 @@ minetest.register_node("nodes:tnt", {
paramtype = "light",
groups = {node = 1},
on_trigger = tnt_explode,
sounds = sounds.wood,
})
minetest.register_node("nodes:tnt_diggable", {
@ -972,6 +975,7 @@ minetest.register_node("nodes:tnt_diggable", {
paramtype = "light",
groups = {node = 1, hand = 1},
on_trigger = tnt_explode,
sounds = sounds.wood,
})
frame.register("nodes:tnt_diggable")
@ -1208,7 +1212,6 @@ minetest.register_node("nodes:lava_source", {
damage_per_second = 4 * 2,
post_effect_color = {a = 191, r = 255, g = 64, b = 0},
groups = {lava = 3, liquid = 2, igniter = 1},
sounds = sounds.water,
})
minetest.register_node("nodes:lava_flowing", {
@ -1256,7 +1259,6 @@ minetest.register_node("nodes:lava_flowing", {
post_effect_color = {a = 191, r = 255, g = 64, b = 0},
groups = {lava = 3, liquid = 2, igniter = 1,
not_in_creative_inventory = 1},
sounds = sounds.water,
})
-- lava cooling ABM
@ -1440,6 +1442,7 @@ for _, names in ipairs({
end
return itemstack
end,
sounds = sounds.wood,
})
end
minetest.register_alias("nodes:chest_with_boxes_findme_item", "nodes:chest_with_boxes_nexus")
@ -1457,6 +1460,7 @@ minetest.register_node("nodes:chest_open", {
minetest.swap_node(pos, {name = "nodes:chest_with_nothing", param2 = node.param2})
end,
groups = {node = 0},
sounds = sounds.wood,
})
@ -1573,7 +1577,7 @@ for _, n in pairs({
type = "fixed",
fixed = {-1/4, -1/2, -1/4, 1/4, 1/2, 1/4},
},
sounds = sounds.wood,
sounds = sounds.stone,
groups = {node = 1},
})
end
@ -1646,7 +1650,7 @@ minetest.register_node("nodes:flowerpot_empty", {
type = "fixed",
fixed = {-1/4, -1/2, -1/4, 1/4, 1/2, 1/4},
},
sounds = sounds.wood,
sounds = sounds.stone,
groups = {node = 1},
})

View File

@ -2,3 +2,4 @@ boxes
log
ranks?
fsc
sounds

View File

@ -293,6 +293,7 @@ minetest.register_node("signs:sign_wall", {
inventory_image = "sign.png",
walkable = false,
tiles = {"sign.png"},
sounds = sounds.wood,
groups = { node = 1, sign = 1 },
selection_box = {
type = "fixed",
@ -507,6 +508,7 @@ minetest.register_node("signs:bg", {
description = "Sign background",
tiles = {"sign_bg.png"},
groups = { node = 1 },
sounds = sounds.stone,
})
local icons = {

View File

@ -2,3 +2,4 @@ mech
rules
log
fsc
sounds

View File

@ -446,4 +446,5 @@ minetest.register_node("terminal:terminal", {
meta:mark_as_private("locked")
end,
on_rightclick = terminal_use,
sounds = sounds.metal,
})