redis/hiredis
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Valgrind returns error exit code when errors found (#1011)

Browse Source 
By default Valgrind will return the exit code from the tested process.
Since our test can return 0 (ALL TESTS PASS) even when a leak was
found we need to tell Valgrind to return an error code.
This will fail the CI job when issues are found.
This commit is contained in:
Bjorn Svensson 2021-11-25 08:09:23 +01:00 committed by GitHub
parent 1aed21a8c5
commit b5716ee829
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/build.yml vendored
View File

@ -36,7 +36,7 @@ jobs:
# - name: Run tests under valgrind # - name: Run tests under valgrind
# env: # env:
# SKIPS_AS_FAILS: 1 # SKIPS_AS_FAILS: 1
# TEST_PREFIX: valgrind --track-origins=yes --leak-check=full # TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full
# run: $GITHUB_WORKSPACE/test.sh # run: $GITHUB_WORKSPACE/test.sh
centos7: centos7:
@ -75,7 +75,7 @@ jobs:
env: env:
SKIPS_AS_FAILS: 1 SKIPS_AS_FAILS: 1
TEST_SSL: 1 TEST_SSL: 1
TEST_PREFIX: valgrind --track-origins=yes --leak-check=full TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full
run: $GITHUB_WORKSPACE/test.sh run: $GITHUB_WORKSPACE/test.sh
centos8: centos8:
@ -115,7 +115,7 @@ jobs:
env: env:
SKIPS_AS_FAILS: 1 SKIPS_AS_FAILS: 1
TEST_SSL: 1 TEST_SSL: 1
TEST_PREFIX: valgrind --track-origins=yes --leak-check=full TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full
run: $GITHUB_WORKSPACE/test.sh run: $GITHUB_WORKSPACE/test.sh
macos: macos: