Password validation plugin (#45)

* Password validation plugin

* Actually forward last_login value from session handler

* Custom auth handler compat, show form for returning player

plugin/init.lua

@@ -41,5 +41,8 @@ load_plugin("announce", false)
 -- Adds command "/force2channel channel,player"
 load_plugin("force2channel", true)
 
+-- Adds complaints for bad password (default or empty)
+load_plugin("password", true)
+
 -- Adds logging and info messages for certain events
 load_plugin("event-logging", true)

plugin/password.lua

@@ -0,0 +1,62 @@
+
+local default_password = minetest.settings:get("default_password")
+if not default_password then
+	-- Do not use if default password is not set
+	return
+end
+
+local only_new_players = minetest.settings:get("beerchat.password.mode") == "new"
+local show_formspec = minetest.settings:get_bool("beerchat.password.use_form", true)
+local message = minetest.settings:get("beerchat.password.message") or "*** Please change your password"
+local fs_message = minetest.formspec_escape(message)
+
+local password_notify = {}
+
+local function validate_password(name)
+	local auth_data = minetest.get_auth_handler().get_auth(name)
+	if auth_data and auth_data.password then
+		return not (minetest.check_password_entry(name, auth_data.password, default_password)
+			or minetest.check_password_entry(name, auth_data.password, ""))
+	end
+	return true
+end
+
+beerchat.register_callback('after_joinplayer', function(player, last_login)
+	if not only_new_players or last_login == nil then
+		local name = player:get_player_name()
+		if not validate_password(name) then
+			password_notify[name] = minetest.get_us_time()
+			minetest.chat_send_player(name, "\n" .. message)
+			if last_login and show_formspec then
+				-- Formspec notification if player has not changed password during first login
+				minetest.show_formspec(name, "MT_PAUSE_MENU",
+					"formspec_version[3]size[14,3]bgcolor[#66F;both;]button_exit[0.5,0.5;13,1;ok;I will]"
+					.. "style_type[*;textcolor=#F00;font_size=*1.2]label[0.5,2;".. fs_message .."]"
+				)
+			end
+		end
+	end
+end)
+
+beerchat.register_callback('before_send', function(name)
+	-- Only run checks if account is marked for notifications
+	if password_notify[name] then
+		if minetest.get_us_time() - password_notify[name] > 4000000 then
+			-- If marked at login do validation again every 4 seconds
+			if validate_password(name) then
+				-- Password was updated and is now valid, stop complaining
+				password_notify[name] = nil
+				return
+			else
+				password_notify[name] = minetest.get_us_time()
+			end
+		end
+		-- Complain about bad password, this can continue for few seconds after password change
+		minetest.chat_send_player(name, message)
+	end
+end)
+
+minetest.register_on_leaveplayer(function(player)
+	local name = player:get_player_name()
+	password_notify[name] = nil
+end)

session.lua

@@ -1,6 +1,6 @@
 
 
-minetest.register_on_joinplayer(function(player)
+minetest.register_on_joinplayer(function(player, last_login)
 
 	local name = player:get_player_name()
 	local meta = player:get_meta()
@@ -21,7 +21,7 @@ minetest.register_on_joinplayer(function(player)
 		beerchat.currentPlayerChannel[name] = beerchat.main_channel_name
 	end
 
-	beerchat.execute_callbacks("after_joinplayer", player)
+	beerchat.execute_callbacks("after_joinplayer", player, last_login)
 
 end)