minetest/docker_test_harness-cd2025
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(base.lua): improve run_tests function logic

Browse Source 
Refactor the run_tests function in base.lua to enhance its logic and readability. The changes ensure proper handling of the tests_state enumeration.
This commit is contained in:
Yves-Marie Haussonne 2024-10-02 11:12:18 +02:00
parent 14860ab625
commit 199abfba88
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
base.lua
View File

@ -554,10 +554,14 @@ local run_tests = function()
end end
print("Server tests done, " .. failed .. " tests failed.") print("Server tests done, " .. failed .. " tests failed.")
if minetest.settings:get_bool("test_harness_stop_server", true) and next(players_tests) == nil then if minetest.settings:get_bool("test_harness_stop_server", true) and ( next(players_tests) == nil or tests_state == TESTS_STATE_ENUM.DONE) then
request_shutdown() request_shutdown()
end end
if tests_state == TESTS_STATE_ENUM.DONE then
return
end
-- list of needed players -- list of needed players
local players_table = {} local players_table = {}
for _, t in ipairs(players_tests) do for _, t in ipairs(players_tests) do
@ -591,13 +595,12 @@ local run_tests = function()
end) end)
minetest.register_on_leaveplayer(function(player, timeout) minetest.register_on_leaveplayer(function(player, timeout)
if tests_state ~= TESTS_STATE_ENUM.STARTED_PLAYERS then if tests_state ~= TESTS_STATE_ENUM.STARTED_PLAYERS then return end
-- check that needed playernames is still in the list of connected players -- check that needed playernames is still in the list of connected players
local connected_player_names = get_connected_player_names() local connected_player_names = get_connected_player_names()
if not all_in_table(needed_playernames, connected_player_names) then if not all_in_table(needed_playernames, connected_player_names) then
tests_state = TESTS_STATE_ENUM.STARTED tests_state = TESTS_STATE_ENUM.STARTED
end end
end
end) end)
end) end)
end end