lua client API: Fix crash in get_server_info()

When running on a local machine in Docker, calling
`minetest.get_server_info()` in lua can throw an exception, resulting
in client shutdown.

    ERROR[Main]: ModError: Failed to load and run mod "tchat":
    ERROR[Main]: No address for peer found!
    ERROR[Main]: stack traceback:
    ERROR[Main]: 	[C]: in function 'get_server_info'
    ERROR[Main]: 	tchat:init.lua:118: in main chunk
    ERROR[Main]: Check debug.txt for details.

clientmods/autofly/init.lua

@@ -296,7 +296,7 @@ function autofly.display_waypoint(name)
     local pos=name
     if type(name) ~= 'table' then pos=autofly.get_waypoint(name) end
     autofly.last_name = name
-    --autofly.last_coords = pos
+    autofly.last_coords = pos
     autofly.set_hud_info(name)
     autofly.aim(autofly.last_coords)
     autofly.display(pos,name)

clientmods/autofly/wpforms.lua

@@ -6,7 +6,6 @@
 local formspec_list = {}
 local selected_name = false
 
-local storage = minetest.get_mod_storage()
 local wpr=false;
 local twpname=nil
 local info=minetest.get_server_info()

clientmods/dte/init.lua

@@ -372,6 +372,7 @@ end
 local function load_UI(name)  -- open/create a ui file
     current_ui_file = name
     modstorage:set_string("_GUI_editor_selected_file", current_ui_file)
+    local _
     _, widgets = pcall(loadstring("return "..modstorage:get_string("_GUI_editor_file_"..current_ui_file)))
     if widgets == nil then
         widgets = {{type="Display", name="", width=5, height=5, width_param=false, height_param=false, left=0.5, top=0.5,

clientmods/incrementaltp/mod.conf

@@ -0,0 +1,4 @@
+name = incrementaltp
+author = cora
+description = Teleport to a destination in increments
+optional_depends = autofly

clientmods/mods.conf

@@ -43,7 +43,7 @@ load_mod_combat = true
 load_mod_waterbot = true
 load_mod_bookbot = true
 load_mod_invrefill = true
-load_mod_haxnotify = true
+load_mod_haxnotify = false
 load_mod_incrementaltp = true
 load_mod_test = true
 load_mod_dodgebot = false

clientmods/scaffold/init.lua

@@ -10,8 +10,6 @@ scaffold.constrain1 = false
 scaffold.constrain2 = false
 local hwps={}
 
-local storage=minetest.get_mod_storage()
-
 scaffold.wason = {}
 
 local nextact = {}

clientmods/scaffold/railscaffold.lua

@@ -4,7 +4,7 @@
 --west:-x,1.5,-5
 --east:-x,1.5,5
 -- north 5,1.5(3096:2.5,25025:1.5),z
---#local storage = minetest.get_mod_storage()
+local storage = minetest.get_mod_storage()
 local ground = {
     "mesecons_torch:redstoneblock"
 }
@@ -148,7 +148,7 @@ end,function() --stopfunc
 end,{'afly_axissnap','continuous_forward','autorefill'}) --'scaffold_ltbm'
 
 ws.on_connect(function()
-        sdir=storage:get_string('BOTDIR')
+        local sdir=storage:get_string('BOTDIR')
         if sdir ~= "" then
             ws.set_dir(sdir)
         else

clientmods/tchat/init.lua

@@ -130,6 +130,9 @@ local message_to = minetest.settings:get("tchat_prefix_send")
 local team_mode = minetest.settings:get_bool("tchat_team_mode")
 
 local use_wisp = minetest.settings:get_bool("tchat_use_wisp")
+if minetest.get_modpath('wisp') == nil then
+   use_wisp = false
+end
 
 local hide_sent = minetest.settings:get_bool("tchat_hide_sent")
 local blacklist = string.split(minetest.settings:get("tchat_blacklist"))
@@ -320,7 +323,7 @@ end
 
 
 local function dm(player, message)
-    if wisp == nil or not use_wisp then
+    if not use_wisp then
         minetest.send_chat_message("/msg " .. player .." " .. message)
     else
         wisp.send(player, message, true)
@@ -534,7 +537,7 @@ table.insert(minetest.registered_on_receiving_chat_message, 1, function(message)
     end
 end)
 
-if wisp ~= nil then
+if use_wisp then
     wisp.register_on_receive_split(function(player, message)
         if message:find(message_prefix) then
             tchat.chat_append("E " .. player .. ": " .. clean_message(message))

clientmods/tchat/mod.conf

@@ -1,3 +1,4 @@
 name = tchat
 author = cora, system32
 description = Adds a team chat and prevents accidental sending of coordinates. Supports Wisp for encrypting messages.
+optional_depends = wisp

src/script/lua_api/l_client.cpp

@@ -322,16 +322,33 @@ int ModApiClient::l_sound_fade(lua_State *L)
 int ModApiClient::l_get_server_info(lua_State *L)
 {
 	Client *client = getClient(L);
-	Address serverAddress = client->getServerAddress();
-	lua_newtable(L);
-	lua_pushstring(L, client->getAddressName().c_str());
-	lua_setfield(L, -2, "address");
-	lua_pushstring(L, serverAddress.serializeString().c_str());
-	lua_setfield(L, -2, "ip");
-	lua_pushinteger(L, serverAddress.getPort());
-	lua_setfield(L, -2, "port");
-	lua_pushinteger(L, client->getProtoVersion());
-	lua_setfield(L, -2, "protocol_version");
+        lua_newtable(L);
+        try {
+          Address serverAddress = client->getServerAddress();
+	} catch (const con::PeerNotFoundException &) {
+          // Local connection?
+          lua_pushstring(L, "unknown");
+          lua_setfield(L, -2, "address");
+          lua_pushstring(L, "unknown");
+          lua_setfield(L, -2, "ip");
+          lua_pushinteger(L, 0);
+          lua_setfield(L, -2, "port");
+          lua_pushinteger(L, 0);
+          lua_setfield(L, -2, "port");
+          lua_pushinteger(L, 0);
+          lua_setfield(L, -2, "protocol_version");
+          return 1;
+        }
+
+        lua_pushstring(L, client->getAddressName().c_str());
+        lua_setfield(L, -2, "address");
+        lua_pushstring(L, serverAddress.serializeString().c_str());
+        lua_setfield(L, -2, "ip");
+        lua_pushinteger(L, serverAddress.getPort());
+        lua_setfield(L, -2, "port");
+        lua_pushinteger(L, client->getProtoVersion());
+        lua_setfield(L, -2, "protocol_version");
+          
 	return 1;
 }