minetest-stuffs
/
dragonfire-client-dragonfire
1
0
Fork 0
Code Issues 10 Pull Requests 2 Packages Projects Releases 3 Wiki Activity

Add list setting -> chatcmd def for external access #62

Merged
corarona merged 4 commits from list_setting into master 2023-06-23 09:26:34 -07:00
Conversation 5 Commits 4 Files Changed 2
corarona commented 2023-06-20 11:16:44 -07:00 (Migrated from github.com)

This adds the setting name to the listcmd chatcommand to allow external mods to access the mapping between command name and setting.

e.g. https://github.com/corarona/nlist

This adds the setting name to the listcmd chatcommand to allow external mods to access the mapping between command name and setting. e.g. https://github.com/corarona/nlist
LizzyFleckenstein03 commented 2023-06-20 12:20:31 -07:00 (Migrated from github.com)

It's a good addition, but the _df_ prefix is unnecessary since register_list_command is was added by dragonfireclient in the first place.

I'm unsure whether documentation should be added to the ### Chat command definition section or to register_list_command, it'd probably beneficial to add it to both, maybe with the ### Chat command definition forwarding the reader to register_list_command.

It's a good addition, but the `_df_` prefix is unnecessary since `register_list_command` is was added by dragonfireclient in the first place. I'm unsure whether documentation should be added to the `### Chat command definition` section or to `register_list_command`, it'd probably beneficial to add it to both, maybe with the `### Chat command definition` forwarding the reader to `register_list_command`.
👍 1
corarona commented 2023-06-20 13:37:20 -07:00 (Migrated from github.com)

force pushed to change the field to _list_setting

force pushed to change the field to _list_setting
corarona commented 2023-06-20 13:42:02 -07:00 (Migrated from github.com)

Added documentation to both

Added documentation to both
LizzyFleckenstein03 commented 2023-06-21 13:04:35 -07:00 (Migrated from github.com)

I removed the underscore and fixed a missing word in the documentation, I have no further objections. If this is good with you, Squash and Merge.

I removed the underscore and fixed a missing word in the documentation, I have no further objections. If this is good with you, Squash and Merge.
corarona commented 2023-06-23 09:29:54 -07:00 (Migrated from github.com)

i guess it doesn't seem likely minetest would add a field named list_setting but generally i try to stick to that convention.

i guess it doesn't seem likely minetest would add a field named list_setting but generally i try to stick to that convention.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working   
documentation

Improvements or additions to documentation   
duplicate

This issue or pull request already exists   
enhancement

New feature or request   
good first issue

Good for newcomers   
help wanted

Extra attention is needed   
invalid

This doesn't seem right   
question

Further information is requested   
wontfix

This will not be worked on
No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: minetest-stuffs/dragonfire-client-dragonfire#62
There is no content yet.
Delete Branch "list_setting"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?