minenux/minetest-engine-minetest
minenux/minetest-engine-minetest
1
0
Fork 0
Code Pull Requests Releases Activity

antihacks: Patch fast/teleport vulnerability when attached to an entity

Browse Source 
* backported https://github.com/minetest/minetest/pull/10340/commits
* Fixed God Mode
* use core::radToDeg and a single v3f to multiply attachment_pos with
* Use getLength() for diffvec
This commit is contained in:
mckaygerhard 2023-09-17 20:07:12 -04:00
parent e406c1d5f5
commit ed9fcb842e
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/content_sao.cpp
View File

@ -1372,12 +1372,34 @@ std::string PlayerSAO::getPropertyPacket()
bool PlayerSAO::checkMovementCheat() bool PlayerSAO::checkMovementCheat()
{ {
if (isAttached() || m_is_singleplayer || if (m_is_singleplayer ||
g_settings->getBool("disable_anticheat")) { g_settings->getBool("disable_anticheat")) {
m_last_good_position = m_base_position; m_last_good_position = m_base_position;
return false; return false;
} }
if (UnitSAO *parent = dynamic_cast<UnitSAO *>(getParent())) {
v3f attachment_pos;
{
int parent_id;
std::string bone;
v3f attachment_rot;
getAttachment(&parent_id, &bone, &attachment_pos, &attachment_rot);
}
v3f parent_pos = parent->getBasePosition();
f32 diff = m_base_position.getDistanceFromSQ(parent_pos) - attachment_pos.getLengthSQ();
const f32 maxdiff = 4.0f * BS; // fair trade-off value for various latencies
if (diff > maxdiff * maxdiff) {
setBasePosition(parent_pos);
actionstream << "Server: " << m_player->getName()
<< " moved away from parent; diff=" << sqrtf(diff) / BS
<< " resetting position." << std::endl;
return true;
}
// Player movement is locked to the entity. Skip further checks
return false;
}
bool cheated = false; bool cheated = false;
/* /*
Check player movements Check player movements