minenux
/
minetest-engine-minetest
1
0
Fork 0
Code Pull Requests Releases Activity

Fix signed overflow in getPointedThing

pull/155/merge
Bad-Command 2012-07-04 15:06:19 -04:00 committed by Perttu Ahola
parent 15bf9a7026
commit cc10eec6c6
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/game.cpp
View File

@ -367,6 +367,14 @@ PointedThing getPointedThing(Client *client, v3f player_position,
s16 zend = pos_i.Z + (camera_direction.Z>0 ? a : 1); s16 zend = pos_i.Z + (camera_direction.Z>0 ? a : 1);
s16 xend = pos_i.X + (camera_direction.X>0 ? a : 1); s16 xend = pos_i.X + (camera_direction.X>0 ? a : 1);
// Prevent signed number overflow
if(yend==32767)
yend=32766;
if(zend==32767)
zend=32766;
if(xend==32767)
xend=32766;
for(s16 y = ystart; y <= yend; y++) for(s16 y = ystart; y <= yend; y++)
for(s16 z = zstart; z <= zend; z++) for(s16 z = zstart; z <= zend; z++)
for(s16 x = xstart; x <= xend; x++) for(s16 x = xstart; x <= xend; x++)