mikf/gallery-dl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[postprocessor:ugoira] small optimization

Browse Source 
Use tuples instead of lists when extending the list of
command-line arguments.
This commit is contained in:
Mike Fährmann 2020-02-07 17:56:26 +01:00
parent b7eb6cecbb
commit 4a3d2405de
No known key found for this signature in database
GPG Key ID: 5680CA389D365A88
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gallery_dl/postprocessor/ugoira.py
View File

@ -42,7 +42,7 @@ class UgoiraPP(PostProcessor):
if arg == "-vcodec" or arg in ("-c", "-codec") and (
not stream or stream.partition(":")[0] in ("v", "V")):
vcodec = self.args[index + 1]
# use filter if libx264/5 is explicitly or implicitly used
# use filter when using libx264/5
self.prevent_odd = (
vcodec in ("libx264", "libx265") or
not vcodec and self.extension.lower() in ("mp4", "mkv"))
@ -91,12 +91,12 @@ class UgoiraPP(PostProcessor):
# collect command-line arguments
args = [self.ffmpeg]
if rate_in:
args += ["-r", str(rate_in)]
args += ["-i", ffconcat]
args += ("-r", str(rate_in))
args += ("-i", ffconcat)
if rate_out:
args += ["-r", str(rate_out)]
args += ("-r", str(rate_out))
if self.prevent_odd:
args += ["-vf", "crop=iw-mod(iw\\,2):ih-mod(ih\\,2)"]
args += ("-vf", "crop=iw-mod(iw\\,2):ih-mod(ih\\,2)")
if self.args:
args += self.args
self.log.debug("ffmpeg args: %s", args)
@ -106,8 +106,8 @@ class UgoiraPP(PostProcessor):
try:
if self.twopass:
if "-f" not in args:
args += ["-f", self.extension]
args += ["-passlogfile", tempdir + "/ffmpeg2pass", "-pass"]
args += ("-f", self.extension)
args += ("-passlogfile", tempdir + "/ffmpeg2pass", "-pass")
self._exec(args + ["1", "-y", os.devnull])
self._exec(args + ["2", pathfmt.realpath])
else: