kcat/openal-soft
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use an atomic flag to test if a source needs to update

Browse Source
This commit is contained in:
Chris Robinson 2017-03-20 21:25:39 -07:00
parent 42bcf0870d
commit cdfe0d8f5a
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Alc/ALc.c
View File

@ -2254,7 +2254,7 @@ static ALCenum UpdateDeviceParams(ALCdevice *device, const ALCint *attrList)
}
}
source->NeedsUpdate = AL_TRUE;
ATOMIC_FLAG_CLEAR(&source->PropsClean, almemory_order_release);
/* Clear any pre-existing source property structs, in case the
* number of auxiliary sends changed. Playing (or paused) sources

2
OpenAL32/Include/alSource.h
View File

@ -149,7 +149,7 @@ typedef struct ALsource {
ATOMIC(ALboolean) looping;
ALenum NeedsUpdate;
ATOMIC_FLAG PropsClean;
ATOMIC(struct ALsourceProps*) Update;
ATOMIC(struct ALsourceProps*) FreeList;

14
OpenAL32/alSource.c
View File

@ -421,7 +421,7 @@ static ALint Int64ValsByProp(ALenum prop)
if(SourceShouldUpdate(Source, Context)) \
UpdateSourceProps(Source, device->NumAuxSends); \
else \
Source->NeedsUpdate = AL_TRUE; \
ATOMIC_FLAG_CLEAR(&Source->PropsClean, almemory_order_release); \
} while(0)
static ALboolean SetSourcefv(ALsource *Source, ALCcontext *Context, SourceProp prop, const ALfloat *values)
@ -2429,7 +2429,7 @@ AL_API ALvoid AL_APIENTRY alSourcePlayv(ALsizei n, const ALuint *sources)
break;
}
source->NeedsUpdate = AL_FALSE;
ATOMIC_FLAG_TEST_AND_SET(&source->PropsClean, almemory_order_acquire);
UpdateSourceProps(source, device->NumAuxSends);
/* Make sure this source isn't already active, and if not, look for an
@ -2948,7 +2948,10 @@ static void InitSourceParams(ALsource *Source, ALsizei num_sends)
ATOMIC_INIT(&Source->looping, AL_FALSE);
Source->NeedsUpdate = AL_TRUE;
/* No way to do an 'init' here, so just test+set with relaxed ordering and
* ignore the test.
*/
ATOMIC_FLAG_TEST_AND_SET(&Source->PropsClean, almemory_order_relaxed);
ATOMIC_INIT(&Source->Update, NULL);
ATOMIC_INIT(&Source->FreeList, NULL);
@ -3098,11 +3101,8 @@ void UpdateAllSourceProps(ALCcontext *context)
{
ALvoice *voice = context->Voices[pos];
ALsource *source = ATOMIC_LOAD(&voice->Source, almemory_order_acquire);
if(source != NULL && source->NeedsUpdate)
{
source->NeedsUpdate = AL_FALSE;
if(source != NULL && ATOMIC_FLAG_TEST_AND_SET(&source->PropsClean, almemory_order_acq_rel))
UpdateSourceProps(source, num_sends);
}
}
}