jp9000/obs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NVENC: Always use 2PASS_QUALITY rate control

Browse Source 
It does a very decent job at holding a constant bitrate now and has a major
impact on the visual quality. Using the inferior rc mode when CBR padding
is enabled, which propably is the cast almost everywhere, seems like a bad
decision to me.
I wasn't able to spot a notable difference in the quality of the constantness
these two provide, so just removing the framesize capped one.
This commit is contained in:
BtbN 2015-12-08 20:40:40 +01:00
parent 49b78b927e
commit a08e141509
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ObsNvenc/src/NVENCEncoder.cpp
View File

@ -306,10 +306,10 @@ void NVENCEncoder::init()
if (bUseCBR) if (bUseCBR)
{ {
auto filler = AppConfig->GetInt(TEXT("Video Encoding"), TEXT("PadCBR"), 1) != 0; bool filler = AppConfig->GetInt(TEXT("Video Encoding"), TEXT("PadCBR"), 1) != 0;
if (is2PassRC) if (is2PassRC)
{ {
encodeConfig.rcParams.rateControlMode = filler ? NV_ENC_PARAMS_RC_2_PASS_FRAMESIZE_CAP : NV_ENC_PARAMS_RC_2_PASS_QUALITY; encodeConfig.rcParams.rateControlMode = NV_ENC_PARAMS_RC_2_PASS_QUALITY;
} }
else else
{ {