2667ae3fc5
In the vt_h264_video_info function, the format of the video to be encoded is always being set to VIDEO_FORMAT_NV12, dispite the presence of code to set the video format to VIDEO_FORMAT_I420 or VIDEO_FORMAT_I444. This commit fixes that function to respect the video format choice of the user. In addition, whilst testing this fix initially, I also discovered that the 4:4:4 colour format is not supported by the VideoToolbox H264 encoder. Looking at the VideoToolbox code in ffmpeg as a reference, the ffmpeg code errors out if a color format other than NV12 or I420 is set. Therefore, this commit also logs a warning about I444 not being supported, and uses the NV12 default.
OBS Studio <https://obsproject.com> =================================== What is OBS Studio? ------------------- OBS Studio is software designed for capturing, compositing, encoding, recording, and streaming video content, efficiently. It's distributed under the GNU General Public License v2 - see the accompanying COPYING file for more details. Quick Links ----------- - Website: https://obsproject.com - Help/Documentation/Guides: https://github.com/jp9000/obs-studio/wiki - Forums: https://obsproject.com/forum/ - Build Instructions: https://github.com/jp9000/obs-studio/wiki/Install-Instructions - Developer/API Documentation: https://obsproject.com/docs - Bug Tracker: https://obsproject.com/mantis/ (Note: The bug tracker is linked to forum accounts. To use the bug tracker, log in to a forum account) Contributing ------------ - If you wish to contribute code to the project, please make sure to read the coding and commit guidelines: https://github.com/jp9000/obs-studio/blob/master/CONTRIBUTING.rst - Developer/API documentation can be found here: https://obsproject.com/docs - If you wish to contribute translations, do not submit pull requests. Instead, please use Crowdin. For more information read this thread: https://obsproject.com/forum/threads/how-to-contribute-translations-for-obs.16327/ - Other ways to contribute are by helping people out with support on our forums or in our community chat. Please limit support to topics you fully understand -- bad advice is worse than no advice. When it comes to something that you don't fully know or understand, please defer to the official help or official channels.