jp9000/obs-studio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

(API Change) Remove pointers from all typedefs

Browse Source 
Typedef pointers are unsafe.  If you do:
typedef struct bla *bla_t;
then you cannot use it as a constant, such as: const bla_t, because
that constant will be to the pointer itself rather than to the
underlying data.  I admit this was a fundamental mistake that must
be corrected.

All typedefs that were pointer types will now have their pointers
removed from the type itself, and the pointers will be used when they
are actually used as variables/parameters/returns instead.

This does not break ABI though, which is pretty nice.
This commit is contained in:
jp9000
2014-09-25 17:44:05 -07:00
parent 4a06960188
commit c9df41c1e2
146 changed files with 3105 additions and 3079 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
plugins/win-capture/dc-capture.c
View File

@@ -175,11 +175,12 @@ void dc_capture_capture(struct dc_capture *capture, HWND window)
capture->textures_written[capture->cur_tex] = true;
}
static void draw_texture(struct dc_capture *capture, int id, gs_effect_t effect)
static void draw_texture(struct dc_capture *capture, int id,
gs_effect_t *effect)
{
gs_texture_t texture = capture->textures[id];
gs_technique_t tech = gs_effect_get_technique(effect, "Draw");
gs_eparam_t image = gs_effect_get_param_by_name(effect, "image");
gs_texture_t *texture = capture->textures[id];
gs_technique_t *tech = gs_effect_get_technique(effect, "Draw");
gs_eparam_t *image = gs_effect_get_param_by_name(effect, "image");
size_t passes;
gs_effect_set_texture(image, texture);
@@ -198,7 +199,7 @@ static void draw_texture(struct dc_capture *capture, int id, gs_effect_t effect)
gs_technique_end(tech);
}
void dc_capture_render(struct dc_capture *capture, gs_effect_t effect)
void dc_capture_render(struct dc_capture *capture, gs_effect_t *effect)
{
int last_tex = (capture->cur_tex > 0) ?
capture->cur_tex-1 : capture->num_textures-1;
@@ -210,9 +211,9 @@ void dc_capture_render(struct dc_capture *capture, gs_effect_t effect)
draw_texture(capture, last_tex, effect);
}
gs_effect_t create_opaque_effect(void)
gs_effect_t *create_opaque_effect(void)
{
gs_effect_t opaque_effect;
gs_effect_t *opaque_effect;
char *effect_file;
char *error_string = NULL;